| Summary: | [EFL][WK2] Add a null checking condition to in hide() of EwkContextMenu | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Gyuyoung Kim <gyuyoung.kim> | ||||||
| Component: | WebKit EFL | Assignee: | Gyuyoung Kim <gyuyoung.kim> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | cdumez, commit-queue, lucas.de.marchi, rakuco | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
Created attachment 203306 [details]
Patch
Comment on attachment 203306 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=203306&action=review > Source/WebKit2/UIProcess/API/efl/ewk_context_menu.cpp:77 > +bool EwkContextMenu::hide() I'd not change the function semantics: returned 'false' would implicitly mean that menu is not hidden which is not the case. Created attachment 203402 [details]
Patch
(In reply to comment #2) > (From update of attachment 203306 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=203306&action=review > > > Source/WebKit2/UIProcess/API/efl/ewk_context_menu.cpp:77 > > +bool EwkContextMenu::hide() > > I'd not change the function semantics: returned 'false' would implicitly mean that menu is not hidden which is not the case. Ok, I don't have big opinion about it. Changed. Comment on attachment 203402 [details]
Patch
LGTM
Comment on attachment 203402 [details]
Patch
r=me
Comment on attachment 203402 [details] Patch Clearing flags on attachment: 203402 Committed r151062: <http://trac.webkit.org/changeset/151062> All reviewed patches have been landed. Closing bug. |
m_viewImpl is able to be null. So, we need to protect this function against such case. EwkContextMenu::EwkContextMenu() : m_viewImpl(0) , m_contextMenuItems(0) { } EwkContextMenu::EwkContextMenu(Eina_List* items) : m_viewImpl(0) , m_contextMenuItems(0) {