Bug 116984

Summary:

Return earlier if there's no session storage namespace

Product:

WebKit

Reporter:

Anders Carlsson <andersca>

Component:

New Bugs

Assignee:

Anders Carlsson <andersca>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	thorton: review+

Description Anders Carlsson 2013-05-29 12:14:32 PDT

Return earlier if there's no session storage namespace

Comment 1 Anders Carlsson 2013-05-29 12:17:29 PDT

Created attachment 203257 [details]
Patch

Comment 2 WebKit Commit Bot 2013-05-29 12:19:29 PDT

Attachment 203257 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/UIProcess/Storage/StorageManager.cpp']" exit_code: 1
Source/WebKit2/UIProcess/Storage/StorageManager.cpp:465:  Missing spaces around >>  [whitespace/operators] [3]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 Tim Horton 2013-05-29 12:40:34 PDT

Comment on attachment 203257 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=203257&action=review

Seems ok.

>> Source/WebKit2/UIProcess/Storage/StorageManager.cpp:465
>> +    ASSERT((HashMap<uint64_t, RefPtr<SessionStorageNamespace>>::isValidKey(storageNamespaceID)));
> 
> Missing spaces around >>  [whitespace/operators] [3]

We should file a bug about the stylebot.

Comment 4 Anders Carlsson 2013-05-29 12:43:15 PDT

Committed r150925: <http://trac.webkit.org/changeset/150925>