Bug 116984 - Return earlier if there's no session storage namespace
Summary: Return earlier if there's no session storage namespace
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
Depends on:
Reported: 2013-05-29 12:14 PDT by Anders Carlsson
Modified: 2013-05-29 12:43 PDT (History)
1 user (show)

See Also:

Patch (2.91 KB, patch)
2013-05-29 12:17 PDT, Anders Carlsson
thorton: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2013-05-29 12:14:32 PDT
Return earlier if there's no session storage namespace
Comment 1 Anders Carlsson 2013-05-29 12:17:29 PDT
Created attachment 203257 [details]
Comment 2 WebKit Commit Bot 2013-05-29 12:19:29 PDT
Attachment 203257 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/UIProcess/Storage/StorageManager.cpp']" exit_code: 1
Source/WebKit2/UIProcess/Storage/StorageManager.cpp:465:  Missing spaces around >>  [whitespace/operators] [3]
Total errors found: 1 in 2 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Tim Horton 2013-05-29 12:40:34 PDT
Comment on attachment 203257 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=203257&action=review

Seems ok.

>> Source/WebKit2/UIProcess/Storage/StorageManager.cpp:465
>> +    ASSERT((HashMap<uint64_t, RefPtr<SessionStorageNamespace>>::isValidKey(storageNamespaceID)));
> Missing spaces around >>  [whitespace/operators] [3]

We should file a bug about the stylebot.
Comment 4 Anders Carlsson 2013-05-29 12:43:15 PDT
Committed r150925: <http://trac.webkit.org/changeset/150925>