Bug 116969

Summary: [BlackBerry] Handle Host-Only cookies
Product: WebKit Reporter: otcheung
Component: WebKit BlackBerryAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description otcheung 2013-05-29 09:48:54 PDT 
Patch to support host-only cookies.
Comment 1 otcheung 2013-05-29 09:57:11 PDT 
Created attachment 203209 [details]
Patch
Comment 2 otcheung 2013-05-29 09:58:16 PDT 
Created attachment 203211 [details]
Patch
Comment 3 Rob Buis 2013-05-29 10:07:02 PDT 
Comment on attachment 203211 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=203211&action=review

Please try StringBuilder.

> Source/WebCore/platform/blackberry/CookieParser.cpp:270
> +                String defaultHost = "." + m_defaultCookieHost;

Using StringBuilder should be more efficient.
Comment 4 otcheung 2013-05-29 11:17:56 PDT 
Created attachment 203220 [details]
Patch
Comment 5 Rob Buis 2013-05-29 11:21:10 PDT 
Comment on attachment 203220 [details]
Patch

Looks good.
Comment 6 WebKit Commit Bot 2013-05-29 11:46:31 PDT 
Comment on attachment 203220 [details]
Patch

Clearing flags on attachment: 203220

Committed r150916: <http://trac.webkit.org/changeset/150916>
Comment 7 WebKit Commit Bot 2013-05-29 11:46:32 PDT 
All reviewed patches have been landed.  Closing bug.