Bug 116969

Summary: [BlackBerry] Handle Host-Only cookies
Product: WebKit Reporter: otcheung
Component: WebKit BlackBerryAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

otcheung
Reported 2013-05-29 09:48:54 PDT
Patch to support host-only cookies.
Attachments
Patch (7.73 KB, patch)
2013-05-29 09:57 PDT, otcheung 		no flags
DetailsFormatted DiffDiff
Patch (7.77 KB, patch)
2013-05-29 09:58 PDT, otcheung 		no flags
DetailsFormatted DiffDiff
Patch (8.39 KB, patch)
2013-05-29 11:17 PDT, otcheung 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
otcheung
Comment 1 2013-05-29 09:57:11 PDT
Created attachment 203209 [details] Patch
otcheung
Comment 2 2013-05-29 09:58:16 PDT
Created attachment 203211 [details] Patch
Rob Buis
Comment 3 2013-05-29 10:07:02 PDT
Comment on attachment 203211 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=203211&action=review Please try StringBuilder. > Source/WebCore/platform/blackberry/CookieParser.cpp:270 > + String defaultHost = "." + m_defaultCookieHost; Using StringBuilder should be more efficient.
otcheung
Comment 4 2013-05-29 11:17:56 PDT
Created attachment 203220 [details] Patch
Rob Buis
Comment 5 2013-05-29 11:21:10 PDT
Comment on attachment 203220 [details] Patch Looks good.
WebKit Commit Bot
Comment 6 2013-05-29 11:46:31 PDT
Comment on attachment 203220 [details] Patch Clearing flags on attachment: 203220 Committed r150916: <http://trac.webkit.org/changeset/150916>
WebKit Commit Bot
Comment 7 2013-05-29 11:46:32 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.