Summary: | [EFl][WK2] Sub menu items should be of EWK_SUBMENU_TYPE and not checkable | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Michal Pakula vel Rutka <mpakulavelrutka> | ||||||
Component: | WebKit EFL | Assignee: | Michal Pakula vel Rutka <mpakulavelrutka> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | cdumez, commit-queue, gyuyoung.kim, lucas.de.marchi, rakuco | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Michal Pakula vel Rutka
2013-05-29 06:07:49 PDT
Created attachment 203190 [details]
patch
Comment on attachment 203190 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=203190&action=review LGTM. This patch follows a policy of WK2 Context menu C APIs. > Source/WebKit2/ChangeLog:10 > + This patch changes ewk context menu API to match WebKit behaviour, by creating sub menus with WebKit behaviour -> WebKit2 behaviour ? It looks WebKit1 has other behaviour differ from port to port. > Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_context_menu.cpp:103 > + Ewk_Context_Menu_Item* newItem3 = ewk_context_menu_item_new_with_submenu(EWK_CONTEXT_MENU_ITEM_TAG_OTHER, "New Custom Item 3", true, subMenu2); Isn't it better to use other action ? (In reply to comment #2) > (From update of attachment 203190 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=203190&action=review > > LGTM. This patch follows a policy of WK2 Context menu C APIs. > > > Source/WebKit2/ChangeLog:10 > > + This patch changes ewk context menu API to match WebKit behaviour, by creating sub menus with > > WebKit behaviour -> WebKit2 behaviour ? It looks WebKit1 has other behaviour differ from port to port. Ok I will fix it. > > > Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_context_menu.cpp:103 > > + Ewk_Context_Menu_Item* newItem3 = ewk_context_menu_item_new_with_submenu(EWK_CONTEXT_MENU_ITEM_TAG_OTHER, "New Custom Item 3", true, subMenu2); > > Isn't it better to use other action ? I am fix context menu API tests in this bug https://bugs.webkit.org/show_bug.cgi?id=116601. There I am changing TAG_OTHER to TAG_CUSTOM as TAG_OTHER seems to be some kind of WebKit-GTK specific tag. Created attachment 203684 [details]
fixed changelog
Comment on attachment 203684 [details] fixed changelog Clearing flags on attachment: 203684 Committed r151168: <http://trac.webkit.org/changeset/151168> All reviewed patches have been landed. Closing bug. |