Bug 116932

Summary: [Qt] Missing files from build after r150853
Product: WebKit Reporter: Peter Gal <galpeter>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: allan.jensen, commit-queue, jturcotte, kadam, ossy, zarvai
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
speculative fix
none
include path fix none

Peter Gal
Reported 2013-05-29 01:06:23 PDT
After the r150853 the Qt Mac buildbot gives a little error as stated below: ../qt-mountainlion-release/build/Source/WebCore/platform/mac/KURLMac.mm:29:9: fatal error: 'CFURLExtras.h' file not found #import "CFURLExtras.h" ^ 1 error generated. The CFURLExtras.{cpp,h} files are missing from the Qt project files.
Attachments
speculative fix (1.46 KB, patch)
2013-05-29 01:10 PDT, Peter Gal 		no flags
DetailsFormatted DiffDiff
include path fix (981 bytes, patch)
2013-05-29 03:32 PDT, Peter Gal 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Peter Gal
Comment 1 2013-05-29 01:10:49 PDT
Created attachment 203134 [details] speculative fix
Csaba Osztrogonác
Comment 2 2013-05-29 01:27:31 PDT
Comment on attachment 203134 [details] speculative fix rs=me
WebKit Commit Bot
Comment 3 2013-05-29 01:55:57 PDT
Comment on attachment 203134 [details] speculative fix Clearing flags on attachment: 203134 Committed r150878: <http://trac.webkit.org/changeset/150878>
WebKit Commit Bot
Comment 4 2013-05-29 01:55:58 PDT
All reviewed patches have been landed. Closing bug.
Csaba Osztrogonác
Comment 5 2013-05-29 03:11:14 PDT
Reopen, because it wasn't enough, the build is still failing.
Peter Gal
Comment 6 2013-05-29 03:32:27 PDT
Created attachment 203147 [details] include path fix Forgot the include path.
Csaba Osztrogonác
Comment 7 2013-05-29 03:33:23 PDT
Comment on attachment 203147 [details] include path fix let's go!
WebKit Commit Bot
Comment 8 2013-05-29 04:01:07 PDT
Comment on attachment 203147 [details] include path fix Clearing flags on attachment: 203147 Committed r150882: <http://trac.webkit.org/changeset/150882>
WebKit Commit Bot
Comment 9 2013-05-29 04:01:10 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.