Bug 116930
| Summary: | Node::isDescendantOf should be aware of shadow dom tree | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> |
| Component: | DOM | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED INVALID | ||
| Severity: | Normal | CC: | ahmad.saleem792, ap, bfulgham, kling, koivisto, rniwa |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Ryosuke Niwa
Consider merging https://chromium.googlesource.com/chromium/blink/+/99c70c6ab825229bff904c9c7b95339cd5c417ac
If a given node is a document node, Node::isDescendantOf should check
whether another node is in a shadow tree or not.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Ahmad Saleem
Webkit GitHub Source:
https://github.com/WebKit/WebKit/blob/b528234195932d576b2fe38eef3bdde6a9e7a099/Source/WebCore/dom/Node.cpp#L1025
____
return &treeScope().rootNode() == &other && !isDocumentNode() && isConnected();
____
Chrome Patch-set modifying to:
return document() == other && !isDocumentNode() && inDocument() && !isInShadowTree();
________
rniwa@webkit.org - Is this needed anymore? Thanks!
Ryosuke Niwa
This is invalid at this point.