Bug 116923
| Summary: | Replace reattachIfAttached calls with lazyReattachIfAttached | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> |
| Component: | Layout and Rendering | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED WONTFIX | ||
| Severity: | Normal | CC: | ahmad.saleem792, hyatt, kling, koivisto, simon.fraser |
| Priority: | P2 | Keywords: | BlinkMergeCandidate |
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Ryosuke Niwa
Consider merging https://chromium.googlesource.com/chromium/blink/+/53ff5c99564ef1677df4f3575a206d32557e0eaa
We should always use lazyAttach instead of manually causing reattaches.
reattachIfAttached is bad because it encourages manual reattaching instead
of letting the next style recalc handle it for you which can result in
bad performance. For example setting and unsetting the open attribute on
<dialog> elements causes the synchronous destruction and recreation of the
entire renderer subtree repeatedly. This change makes sure that we defer all
that work until the next style recalc.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Ryosuke Niwa
Also https://chromium.googlesource.com/chromium/blink/+/d5b57e33ccbf9a89912773d1b12374fbc7f715f8
HTMLSelectElement should use lazyReattach
When changing the size attribute on <select> we shouldn't do a sync reattach().
Ahmad Saleem
lazyAttach is not something in Webkit. So marking this as "RESOLVED WONTFIX".