Summary: | fast/js/date-DST-time-cusps.html fails after http://trac.webkit.org/changeset/150833 | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Tim Horton <thorton> | ||||
Component: | Tools / Tests | Assignee: | Gavin Barraclough <barraclough> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | barraclough, jer.noble, thorton | ||||
Priority: | P2 | Keywords: | Regression | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Tim Horton
2013-05-28 15:21:37 PDT
Marked failing in http://trac.webkit.org/changeset/150848. Please fix by the morning or I'll roll out the offending patch. This is actually a progression! Per the description in the test case: "For times that shouldn't happen we currently go back an hour, but in reality we would like to go forward an hour. This has been filed as a radar: 4777813" Now it does! I'll update the expected results. Created attachment 203116 [details]
Update results
Comment on attachment 203116 [details] Update results View in context: https://bugs.webkit.org/attachment.cgi?id=203116&action=review Looks convincing. > LayoutTests/ChangeLog:5 > + <rdar://problem/4777813> Safari incorrectly handles times that shouldn't exist Also <https://bugs.webkit.org/show_bug.cgi?id=11157>, I guess. > LayoutTests/ChangeLog:14 > + - Preffer the latter option for non-existant time (due to clock rolling forwards). Typo: Preffer. Mistake: existant. Looks suspicious to me: forwards. > LayoutTests/fast/js/script-tests/date-DST-time-cusps.js:6 > "For times that happen twice the behavior of all major browsers seems to be to pick the second occurance, i.e. Standard Time not Daylight Time" Mistake: occurrance. |