Bug 116883

Summary:

Web Inspector: Remove console.profiles from window.console API

Product:

WebKit

Reporter:

Joseph Pecoraro <joepeck>

Component:

Web Inspector

Assignee:

Joseph Pecoraro <joepeck>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, cdumez, commit-queue, esprehn+autocc, graouts, gyuyoung.kim, joepeck, kondapallykalyan, rakuco, rniwa, timothy, webkit-bug-importer, yurys

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
[PATCH] Proposed Fix	buildbot: commit-queue-
Archive of layout-test-results from webkit-ews-07 for mac-mountainlion	none
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2	none
[PATCH] Proposed Fix	timothy: review+
[PATCH] For Bots	none

Joseph Pecoraro

Reported 2013-05-28 13:21:15 PDT

Blink did this. I agree, we should too. <https://chromium.googlesource.com/chromium/blink/+/6896b8cc83bc337bca452e85b8db0939cc1873ca> > This change removes profiles property from window.console > objec and all related classes. > console.profile/profileEnd can still be used to record > profile but the profiles themselves should be retrieved > only using remote debugging protocol.

Attachments
[PATCH] Proposed Fix (37.51 KB, patch) 2013-08-14 15:01 PDT, Joseph Pecoraro	buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from webkit-ews-07 for mac-mountainlion (453.62 KB, application/zip) 2013-08-14 16:22 PDT, Build Bot	no flags	Details
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2 (502.71 KB, application/zip) 2013-08-16 11:39 PDT, Build Bot	no flags	Details
[PATCH] Proposed Fix (7.55 KB, patch) 2014-02-25 17:32 PST, Joseph Pecoraro	timothy: review+	Details Formatted Diff Diff
[PATCH] For Bots (10.11 KB, patch) 2014-02-25 18:02 PST, Joseph Pecoraro	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2013-05-28 13:21:26 PDT

<rdar://problem/14004223>

Joseph Pecoraro

Comment 2 2013-08-14 15:01:39 PDT

Created attachment 208762 [details] [PATCH] Proposed Fix Remove console.profiles and related code.

Build Bot

Comment 3 2013-08-14 16:22:04 PDT

Comment on attachment 208762 [details] [PATCH] Proposed Fix Attachment 208762 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/1453986 New failing tests: fast/profiler/document-dot-write.html fast/profiler/nested-anonymous-functon.html fast/profiler/anonymous-function-calls-built-in-functions.html fast/profiler/built-in-function-calls-anonymous.html fast/profiler/apply.html fast/profiler/built-in-function-calls-user-defined-function.html fast/profiler/multiple-and-different-scoped-anonymous-function-calls.html http/tests/inspector/inspect-element.html fast/profiler/nested-start-and-stop-profiler.html fast/profiler/execution-context-and-eval-on-same-line.html fast/profiler/multiple-and-different-scoped-function-calls.html fast/profiler/one-execution-context.html fast/profiler/compare-multiple-profiles.html fast/profiler/multiple-anonymous-functions-called-from-the-same-function.html fast/profiler/named-functions-with-display-names.html fast/profiler/no-execution-context.html fast/profiler/inline-event-handler.html fast/profiler/multiple-frames.html fast/profiler/profiling-from-a-nested-location-but-stop-profiling-outside-the-nesting.html fast/profiler/anonymous-functions-with-display-names.html fast/profiler/anonymous-function-calls-eval.html fast/profiler/call.html fast/profiler/profile-with-no-title.html fast/profiler/many-calls-in-the-same-scope.html fast/profiler/calling-the-function-that-started-the-profiler-from-another-scope.html fast/profiler/constructor.html fast/profiler/anonymous-event-handler.html fast/profiler/anonymous-function-called-from-different-contexts.html fast/profiler/event-handler.html fast/profiler/profile-calls-in-included-file.html

Build Bot

Comment 4 2013-08-14 16:22:06 PDT

Created attachment 208769 [details] Archive of layout-test-results from webkit-ews-07 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-07 Port: mac-mountainlion Platform: Mac OS X 10.8.4

Joseph Pecoraro

Comment 5 2013-08-14 17:48:03 PDT

Hmm, it looks like there are a bunch of fast/profiler tests that depend on console.profiles.

Build Bot

Comment 6 2013-08-16 11:39:24 PDT

Comment on attachment 208762 [details] [PATCH] Proposed Fix Attachment 208762 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/1465745 New failing tests: fast/profiler/document-dot-write.html fast/profiler/nested-anonymous-functon.html fast/profiler/anonymous-function-calls-built-in-functions.html fast/profiler/multiple-frames.html fast/profiler/apply.html fast/profiler/built-in-function-calls-user-defined-function.html http/tests/inspector/inspect-element.html fast/profiler/execution-context-and-eval-on-same-line.html fast/profiler/nested-start-and-stop-profiler.html fast/profiler/multiple-and-different-scoped-anonymous-function-calls.html fast/profiler/multiple-and-different-scoped-function-calls.html fast/profiler/one-execution-context.html fast/profiler/compare-multiple-profiles.html editing/pasteboard/copy-image-with-alt-text.html fast/profiler/multiple-anonymous-functions-called-from-the-same-function.html fast/profiler/named-functions-with-display-names.html fast/profiler/no-execution-context.html fast/profiler/inline-event-handler.html fast/profiler/built-in-function-calls-anonymous.html fast/profiler/anonymous-functions-with-display-names.html fast/profiler/anonymous-function-calls-eval.html fast/profiler/call.html fast/profiler/many-calls-in-the-same-scope.html fast/profiler/calling-the-function-that-started-the-profiler-from-another-scope.html fast/profiler/constructor.html fast/profiler/anonymous-event-handler.html fast/profiler/anonymous-function-called-from-different-contexts.html fast/profiler/event-handler.html fast/profiler/profile-calls-in-included-file.html

Build Bot

Comment 7 2013-08-16 11:39:26 PDT

Created attachment 208936 [details] Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-16 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.4

Timothy Hatcher

Comment 8 2014-01-10 15:37:16 PST

Moving to the right component.

Joseph Pecoraro

Comment 9 2014-02-25 16:31:32 PST

*** Bug 43471 has been marked as a duplicate of this bug. ***

Joseph Pecoraro

Comment 10 2014-02-25 17:30:10 PST

To keep tests working lets just move it to Internals. I have a patch, seems to work fine.

Joseph Pecoraro

Comment 11 2014-02-25 17:32:21 PST

Created attachment 225204 [details] [PATCH] Proposed Fix Lets see what the bots do. fast/profiler tests pass for me.

Joseph Pecoraro

Comment 12 2014-02-25 18:02:39 PST

Created attachment 225207 [details] [PATCH] For Bots

Joseph Pecoraro

Comment 13 2014-02-26 11:29:52 PST

Landed <http://trac.webkit.org/changeset/164730>.

Note You need to log in before you can comment on or make changes to this bug.