Bug 116880

Summary: Create a html/forms subdirectory and move FileIconLoader there
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eflews.bot, esprehn+autocc, gyuyoung.kim, gyuyoung.kim, rakuco
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch jberlin: review+

Anders Carlsson
Reported 2013-05-28 12:39:28 PDT
Create a html/forms subdirectory and move FileIconLoader there
Attachments
Patch (27.96 KB, patch)
2013-05-28 12:51 PDT, Anders Carlsson 		no flags
DetailsFormatted DiffDiff
Patch (28.69 KB, patch)
2013-05-28 12:56 PDT, Anders Carlsson 		no flags
DetailsFormatted DiffDiff
Patch (44.23 KB, patch)
2013-05-28 13:49 PDT, Anders Carlsson 		jberlin: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2013-05-28 12:51:15 PDT
Created attachment 203078 [details] Patch
EFL EWS Bot
Comment 2 2013-05-28 12:54:27 PDT
Comment on attachment 203078 [details] Patch Attachment 203078 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/732029
Anders Carlsson
Comment 3 2013-05-28 12:56:18 PDT
Created attachment 203079 [details] Patch
Build Bot
Comment 4 2013-05-28 13:20:02 PDT
Comment on attachment 203079 [details] Patch Attachment 203079 [details] did not pass win-ews (win): Output: http://webkit-queues.appspot.com/results/718394
EFL EWS Bot
Comment 5 2013-05-28 13:30:39 PDT
Comment on attachment 203079 [details] Patch Attachment 203079 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/743174
Anders Carlsson
Comment 6 2013-05-28 13:49:37 PDT
Created attachment 203085 [details] Patch
Jessie Berlin
Comment 7 2013-05-28 14:41:01 PDT
Comment on attachment 203085 [details] Patch r=me assuming you watch the windows bots after you land (since it didn’t apply to win ews).
Anders Carlsson
Comment 8 2013-05-28 14:50:30 PDT
Committed r150837: <http://trac.webkit.org/changeset/150837>
Darin Adler
Comment 9 2013-05-28 14:51:42 PDT
Comment on attachment 203085 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=203085&action=review > Source/WebCore/ChangeLog:11 > + Begin my moving FileIconLoader from platform to html/forms. It is related to HTML forms (it's only used by s/my/by/
Note You need to log in before you can comment on or make changes to this bug.