Bug 116880 - Create a html/forms subdirectory and move FileIconLoader there
Summary: Create a html/forms subdirectory and move FileIconLoader there
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-05-28 12:39 PDT by Anders Carlsson
Modified: 2013-05-28 14:51 PDT (History)
6 users (show)

See Also:


Attachments
Patch (27.96 KB, patch)
2013-05-28 12:51 PDT, Anders Carlsson
no flags Details | Formatted Diff | Diff
Patch (28.69 KB, patch)
2013-05-28 12:56 PDT, Anders Carlsson
no flags Details | Formatted Diff | Diff
Patch (44.23 KB, patch)
2013-05-28 13:49 PDT, Anders Carlsson
jberlin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2013-05-28 12:39:28 PDT
Create a html/forms subdirectory and move FileIconLoader there
Comment 1 Anders Carlsson 2013-05-28 12:51:15 PDT
Created attachment 203078 [details]
Patch
Comment 2 EFL EWS Bot 2013-05-28 12:54:27 PDT
Comment on attachment 203078 [details]
Patch

Attachment 203078 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/732029
Comment 3 Anders Carlsson 2013-05-28 12:56:18 PDT
Created attachment 203079 [details]
Patch
Comment 4 Build Bot 2013-05-28 13:20:02 PDT
Comment on attachment 203079 [details]
Patch

Attachment 203079 [details] did not pass win-ews (win):
Output: http://webkit-queues.appspot.com/results/718394
Comment 5 EFL EWS Bot 2013-05-28 13:30:39 PDT
Comment on attachment 203079 [details]
Patch

Attachment 203079 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/743174
Comment 6 Anders Carlsson 2013-05-28 13:49:37 PDT
Created attachment 203085 [details]
Patch
Comment 7 Jessie Berlin 2013-05-28 14:41:01 PDT
Comment on attachment 203085 [details]
Patch

r=me assuming you watch the windows bots after you land (since it didn’t apply to win ews).
Comment 8 Anders Carlsson 2013-05-28 14:50:30 PDT
Committed r150837: <http://trac.webkit.org/changeset/150837>
Comment 9 Darin Adler 2013-05-28 14:51:42 PDT
Comment on attachment 203085 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=203085&action=review

> Source/WebCore/ChangeLog:11
> +        Begin my moving FileIconLoader from platform to html/forms. It is related to HTML forms (it's only used by

s/my/by/