Bug 116879

Summary: [BlackBerry] Use lazily-backed backingstore tiles
Product: WebKit Reporter: Jakob Petsovits <jpetsovits>
Component: WebKit BlackBerryAssignee: Jakob Petsovits <jpetsovits>
Status: RESOLVED FIXED    
Severity: Normal CC: anilsson, cgarcia, commit-queue, mlattanzio, rwlbuis
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Jakob Petsovits
Reported 2013-05-28 12:22:19 PDT
Lazy backing has advanced enough to be used for backingstore tiles without drawbacks. Let's switch over to those.
Attachments
Patch (5.34 KB, patch)
2013-05-28 12:30 PDT, Jakob Petsovits 		no flags
DetailsFormatted DiffDiff
Patch (5.29 KB, patch)
2013-05-29 08:15 PDT, Jakob Petsovits 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jakob Petsovits
Comment 1 2013-05-28 12:30:47 PDT
Created attachment 203077 [details] Patch
Arvid Nilsson
Comment 2 2013-05-28 12:33:56 PDT
Comment on attachment 203077 [details] Patch LGTM
Mike Lattanzio
Comment 3 2013-05-28 12:37:14 PDT
Unofficial r+. Very happy about this.
Carlos Garcia Campos
Comment 4 2013-05-29 00:05:20 PDT
Comment on attachment 203077 [details] Patch Looks great, but the patch doesn't seem to apply upstream.
Jakob Petsovits
Comment 5 2013-05-29 08:15:25 PDT
Created attachment 203201 [details] Patch Thanks Carlos. Apparently the use of BlackBerry::Platform::StringBuilder in AboutData.cpp hasn't made it upstream, that's what caused the conflict. Luckily it's just as easy to delete the same line in the old code, so I'll retain the review and cq+ it right away.
WebKit Commit Bot
Comment 6 2013-05-29 08:36:47 PDT
Comment on attachment 203201 [details] Patch Clearing flags on attachment: 203201 Committed r150896: <http://trac.webkit.org/changeset/150896>
WebKit Commit Bot
Comment 7 2013-05-29 08:36:48 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.