Bug 116842

Summary:

Move hasNonEmptyBoundingBox from Node to HTMLAnchorElement

Product:

WebKit

Reporter:

Darin Adler <darin>

Component:

DOM

Assignee:

Darin Adler <darin>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, commit-queue, esprehn+autocc, glenn, kling, koivisto, philn, rniwa, webkit-ews, xan.lopez

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	koivisto: review+, webkit-ews: commit-queue-

Darin Adler

Reported 2013-05-27 13:43:56 PDT

Move hasNonEmptyBoundingBox from Node to RenderBoxModelObject

Attachments
Patch (6.62 KB, patch) 2013-05-27 13:51 PDT, Darin Adler	no flags	Details Formatted Diff Diff
Patch (6.55 KB, patch) 2013-05-27 13:51 PDT, Darin Adler	no flags	Details Formatted Diff Diff
Patch (5.24 KB, patch) 2013-05-27 16:28 PDT, Darin Adler	koivisto: review+ webkit-ews: commit-queue-	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Darin Adler

Comment 1 2013-05-27 13:51:21 PDT

Created attachment 203007 [details] Patch

Darin Adler

Comment 2 2013-05-27 13:51:46 PDT

Created attachment 203008 [details] Patch

Antti Koivisto

Comment 3 2013-05-27 16:00:05 PDT

Comment on attachment 203008 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=203008&action=review > Source/WebCore/ChangeLog:3 > + Move hasNonEmptyBoundingBox from Node to RenderBoxModelObject Why there? > Source/WebCore/html/HTMLAnchorElement.cpp:125 > - return hasNonEmptyBoundingBox(); > + RenderBoxModelObject* renderer = renderBoxModelObject(); > + return renderer && renderer->hasNonEmptyBox(); Unless this is going to have other clients I would just put it to HTMLAnchorElement. No need to bloat RenderBoxModelObject with questionable special case functions like this (any more than Node). > Source/WebCore/rendering/RenderBoxModelObject.h:178 > + bool hasNonEmptyBox() const; isEmpty()?

Darin Adler

Comment 4 2013-05-27 16:18:44 PDT

Comment on attachment 203008 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=203008&action=review >> Source/WebCore/html/HTMLAnchorElement.cpp:125 >> + return renderer && renderer->hasNonEmptyBox(); > > Unless this is going to have other clients I would just put it to HTMLAnchorElement. No need to bloat RenderBoxModelObject with questionable special case functions like this (any more than Node). OK.

Darin Adler

Comment 5 2013-05-27 16:28:51 PDT

Created attachment 203015 [details] Patch

Antti Koivisto

Comment 6 2013-05-27 16:34:57 PDT

Comment on attachment 203015 [details] Patch r=me

Early Warning System Bot

Comment 7 2013-05-27 16:36:57 PDT

Comment on attachment 203015 [details] Patch Attachment 203015 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/683217

Early Warning System Bot

Comment 8 2013-05-27 16:40:44 PDT

Comment on attachment 203015 [details] Patch Attachment 203015 [details] did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/683218