Summary: | Move hasNonEmptyBoundingBox from Node to HTMLAnchorElement | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Darin Adler <darin> | ||||||||
Component: | DOM | Assignee: | Darin Adler <darin> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | buildbot, commit-queue, esprehn+autocc, glenn, kling, koivisto, philn, rniwa, webkit-ews, xan.lopez | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | All | ||||||||||
OS: | All | ||||||||||
Attachments: |
|
Description
Darin Adler
2013-05-27 13:43:56 PDT
Created attachment 203007 [details]
Patch
Created attachment 203008 [details]
Patch
Comment on attachment 203008 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=203008&action=review > Source/WebCore/ChangeLog:3 > + Move hasNonEmptyBoundingBox from Node to RenderBoxModelObject Why there? > Source/WebCore/html/HTMLAnchorElement.cpp:125 > - return hasNonEmptyBoundingBox(); > + RenderBoxModelObject* renderer = renderBoxModelObject(); > + return renderer && renderer->hasNonEmptyBox(); Unless this is going to have other clients I would just put it to HTMLAnchorElement. No need to bloat RenderBoxModelObject with questionable special case functions like this (any more than Node). > Source/WebCore/rendering/RenderBoxModelObject.h:178 > + bool hasNonEmptyBox() const; isEmpty()? Comment on attachment 203008 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=203008&action=review >> Source/WebCore/html/HTMLAnchorElement.cpp:125 >> + return renderer && renderer->hasNonEmptyBox(); > > Unless this is going to have other clients I would just put it to HTMLAnchorElement. No need to bloat RenderBoxModelObject with questionable special case functions like this (any more than Node). OK. Created attachment 203015 [details]
Patch
Comment on attachment 203015 [details]
Patch
r=me
Comment on attachment 203015 [details] Patch Attachment 203015 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/683217 Comment on attachment 203015 [details] Patch Attachment 203015 [details] did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/683218 Comment on attachment 203015 [details] Patch Attachment 203015 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/666066 Committed r150783: <http://trac.webkit.org/changeset/150783> Mass move bugs into the DOM component. |