Bug 116811

Summary: Add a balanced benchmark for QuerySelector
Product: WebKit Reporter: Benjamin Poulain <benjamin>
Component: New BugsAssignee: Benjamin Poulain <benjamin>
Status: RESOLVED FIXED    
Severity: Normal CC: rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch sam: review+

Benjamin Poulain
Reported 2013-05-27 01:52:07 PDT
Add a balanced benchmark for QuerySelector
Attachments
Patch (16.73 KB, patch)
2013-05-27 02:04 PDT, Benjamin Poulain 		sam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Benjamin Poulain
Comment 1 2013-05-27 02:04:40 PDT
Created attachment 202955 [details] Patch
Benjamin Poulain
Comment 2 2013-05-27 02:07:49 PDT
I get 0.59% when run with run-pert-tests. 1.2% when run in Safari. By the way, there are other weird tests for query selectors. And they are in Parser/ for some reason.
Ryosuke Niwa
Comment 3 2013-05-27 13:51:56 PDT
Comment on attachment 202955 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=202955&action=review > PerformanceTests/ChangeLog:18 > + * DOM/QuerySelector.html: Added. > + * DOM/resources/query-selector.html: Added. We shouldn't be adding new tests to DOM for now since they're tests imported from chromium's dom_perf test. They are two tests misplaced there but...
Benjamin Poulain
Comment 4 2013-05-27 14:09:14 PDT
> > PerformanceTests/ChangeLog:18 > > + * DOM/QuerySelector.html: Added. > > + * DOM/resources/query-selector.html: Added. > > We shouldn't be adding new tests to DOM for now since they're tests imported from chromium's dom_perf test. > They are two tests misplaced there but... Okay, that explain why the others are in Parser/. Any suggestion where to put this test?
Ryosuke Niwa
Comment 5 2013-05-27 14:51:20 PDT
(In reply to comment #4) > > Okay, that explain why the others are in Parser/. > Any suggestion where to put this test? CSS?
Benjamin Poulain
Comment 6 2013-05-27 15:30:55 PDT
Committed r150781: <http://trac.webkit.org/changeset/150781>
Note You need to log in before you can comment on or make changes to this bug.