Bug 116799

Summary: Plugins with no src but valid type should not snapshot
Product: WebKit Reporter: Dean Jackson <dino>
Component: Plug-insAssignee: Dean Jackson <dino>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, jonlee, thorton
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch simon.fraser: review+

Dean Jackson
Reported 2013-05-26 16:11:49 PDT
There are a few plugins in the wild that don't take any src attribute - they simply load the plugin from the mime type. Google Hangouts is an example.
Attachments
Patch (3.09 KB, patch)
2013-05-26 16:15 PDT, Dean Jackson 		simon.fraser: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dean Jackson
Comment 1 2013-05-26 16:15:27 PDT
Created attachment 202933 [details] Patch
Dean Jackson
Comment 2 2013-05-26 16:19:32 PDT
<rdar://problem/13695911>
Darin Adler
Comment 3 2013-05-26 18:02:58 PDT
Comment on attachment 202933 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=202933&action=review > Source/WebCore/html/HTMLPlugInImageElement.cpp:649 > + if ((m_loadedUrl.isNull() || m_loadedUrl.isEmpty()) && !loadedMimeType().isEmpty()) { No need to write (m_loadedUrl.isNull() || m_loadedUrl.isEmpty()); that’s the same as m_loadedUrl.isEmpty().
Dean Jackson
Comment 4 2013-05-26 18:46:03 PDT
Committed r150731: <http://trac.webkit.org/changeset/150731>
Note You need to log in before you can comment on or make changes to this bug.