| Summary: | Rename FontFallbackList to FontGlyphs | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Antti Koivisto <koivisto> | ||||
| Component: | Text | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | commit-queue, d-r, esprehn+autocc, fmalita, glenn, kling, mitz, pdr, schenney | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Antti Koivisto
2013-05-26 15:48:37 PDT
Created attachment 202931 [details]
patch
Comment on attachment 202931 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=202931&action=review r=me, go go Antti go! > Source/WebCore/platform/graphics/FontFallbackList.cpp:2 > - * Copyright (C) 2006 Apple Computer, Inc. All rights reserved. > + * Copyright (C) 2006, 2013 Apple Computer, Inc. All rights reserved. :D (In reply to comment #0) > Maybe it was a fallback list once. Nowadays its purpose is to cache realized glyphs and related data. I don’t think that’s a good characterization. This object caches realized FontData objects—which are used to key into the glyph cache—but I wouldn’t call them “glyphs and related data”. Even the accessors on this class return FontData instances! (In reply to comment #4) > (In reply to comment #0) > > Maybe it was a fallback list once. Nowadays its purpose is to cache realized glyphs and related data. > > I don’t think that’s a good characterization. This object caches realized FontData objects—which are used to key into the glyph cache—but I wouldn’t call them “glyphs and related data”. Even the accessors on this class return FontData instances! Suggestion welcome! Note that the encapsulation and code moving in bug 116803 gave FontGlyphs a glyph API, significantly reducing need for direct FontData access. Also the vaguely named (Simple)FontData type is in fact largely about providing glyphs and information about glyphs. |