Summary: | CSSParser::parseImageResolution doesn't need a parameter. | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jaehun Lim <ljaehun.lim> | ||||||
Component: | CSS | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, esprehn+autocc, glenn, koivisto, macpherson, menard | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Jaehun Lim
2013-05-24 21:01:53 PDT
Created attachment 202874 [details]
Patch
Comment on attachment 202874 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=202874&action=review > Source/WebCore/css/CSSParser.cpp:2983 > m_valueList->next(); This line of code does not seem necessary. The parseImageResolution function already kept calling next() until it returned 0. This line of code does nothing. Comment on attachment 202874 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=202874&action=review >> Source/WebCore/css/CSSParser.cpp:2983 >> m_valueList->next(); > > This line of code does not seem necessary. The parseImageResolution function already kept calling next() until it returned 0. This line of code does nothing. Yes. I think "if (!parsedValue) / return false;" are redundant, too. parsedValue will be checked after switch case statement. I'll remove these two lines. Created attachment 202941 [details]
Patch
Comment on attachment 202941 [details] Patch Clearing flags on attachment: 202941 Committed r150734: <http://trac.webkit.org/changeset/150734> All reviewed patches have been landed. Closing bug. |