Bug 116746

Summary: Move history property list writer to WebKit
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, beidson, commit-queue, thorton
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch thorton: review+

Description Anders Carlsson 2013-05-24 16:11:23 PDT 
Move history property list writer to WebKit
Comment 1 Anders Carlsson 2013-05-24 16:17:23 PDT 
Created attachment 202864 [details]
Patch
Comment 2 WebKit Commit Bot 2013-05-24 16:19:34 PDT 
Attachment 202864 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/WebCore.exp.in', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/history/cf/HistoryPropertyList.cpp', u'Source/WebCore/history/cf/HistoryPropertyList.h', u'Source/WebCore/platform/cf/BinaryPropertyList.cpp', u'Source/WebCore/platform/cf/BinaryPropertyList.h', u'Source/WebKit/ChangeLog', u'Source/WebKit/WebKit.xcodeproj/project.pbxproj', u'Source/WebKit/mac/ChangeLog', u'Source/WebKit/mac/History/BinaryPropertyList.cpp', u'Source/WebKit/mac/History/BinaryPropertyList.h', u'Source/WebKit/mac/History/HistoryPropertyList.cpp', u'Source/WebKit/mac/History/HistoryPropertyList.h', u'Source/WebKit/mac/History/WebHistory.mm']" exit_code: 1
Source/WebKit/mac/History/BinaryPropertyList.cpp:26:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Source/WebKit/mac/History/HistoryPropertyList.cpp:26:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Total errors found: 2 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Tim Horton 2013-05-24 16:25:23 PDT 
Comment on attachment 202864 [details]
Patch

I assume you'll do The Right Thing when moving the files.
Comment 4 Anders Carlsson 2013-05-24 16:30:12 PDT 
Committed r150665: <http://trac.webkit.org/changeset/150665>
Comment 5 Alexey Proskuryakov 2013-05-26 16:44:27 PDT 
This patch does not have a rationale posted.

Why is this helpful? I thought we wanted to move everything in the opposite direction, making WebKit a thin layer for platform specific APIs.
Comment 6 Anders Carlsson 2013-05-27 13:37:27 PDT 
(In reply to comment #5)
> This patch does not have a rationale posted.
> 
> Why is this helpful? I thought we wanted to move everything in the opposite direction, making WebKit a thin layer for platform specific APIs.

It’s moving code that was only used by WebKit/mac away from WebCore.
Comment 7 Alexey Proskuryakov 2013-05-27 13:51:34 PDT 
Sure, that's what the patch did, I can see that.

What is the rationale? Previously, we never intended to make WebCore lean and mean by making WebKit fat.