Bug 116737 – Make team.html have each contributor's area of expertise

• Component: New Bugs
• Status: RESOLVED FIXED

[Bem Jones-Bey]

Make team.html have each contributor's area of expertise

[Bem Jones-Bey]

Created attachment 202848 [details]
Patch

Add an expertise field and update team.html to read it

[Ryosuke Niwa]

Comment on attachment 202848 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=202848&action=review

> Tools/ChangeLog:13
> +        Changed formatting of the file because the lines are getting way to
> +        long, and I generated this, so it's easier if the formatting of the
> +        file is regular.

Please either revert this change or do it in a separate patch.

[Benjamin Poulain]

Comment on attachment 202848 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=202848&action=review

LGTM :)

Can you please double check the unicode name before cq+?

> Tools/Scripts/webkitpy/common/config/contributors.json:85
> +      "Alexander Færøy" : {

Shouldn't this be u"Ale..."?

[Bem Jones-Bey]

(In reply to comment #3)
> (From update of attachment 202848 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=202848&action=review
> 
> LGTM :)

Hah!

> 
> Can you please double check the unicode name before cq+?
> 
> > Tools/Scripts/webkitpy/common/config/contributors.json:85
> > +      "Alexander Færøy" : {
> 
> Shouldn't this be u"Ale..."?

Looks like the utf-8 got messed up in the upload somewhere. I'll change them to be \u escapes.

[Bem Jones-Bey]

Created attachment 202853 [details]
Patch

Update to use escapes for unicode instead of utf-8, like the original contributors.json did

[WebKit Commit Bot]

Comment on attachment 202853 [details]
Patch

Clearing flags on attachment: 202853

Committed r150662: <http://trac.webkit.org/changeset/150662>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.