Bug 116707

Summary: [EFL][WK2] Remove unneeded WebCore namespace use in ewk
Product: WebKit Reporter: Gyuyoung Kim <gyuyoung.kim>
Component: WebKit EFLAssignee: Gyuyoung Kim <gyuyoung.kim>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, lucas.de.marchi, rakuco
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Gyuyoung Kim
Reported 2013-05-24 00:31:10 PDT
SSIA
Attachments
Patch (1.81 KB, patch)
2013-05-24 00:32 PDT, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Patch (1.87 KB, patch)
2013-05-24 00:40 PDT, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Gyuyoung Kim
Comment 1 2013-05-24 00:32:19 PDT
Created attachment 202778 [details] Patch
Chris Dumez
Comment 2 2013-05-24 00:36:44 PDT
Comment on attachment 202778 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=202778&action=review > Source/WebKit2/UIProcess/API/efl/ewk_security_origin.cpp:33 > #include <WebCore/SecurityOrigin.h> Could we remove this header include as well?
Gyuyoung Kim
Comment 3 2013-05-24 00:40:35 PDT
Created attachment 202779 [details] Patch
Gyuyoung Kim
Comment 4 2013-05-24 00:40:56 PDT
(In reply to comment #2) > (From update of attachment 202778 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=202778&action=review > > > Source/WebKit2/UIProcess/API/efl/ewk_security_origin.cpp:33 > > #include <WebCore/SecurityOrigin.h> > > Could we remove this header include as well? Sure !
Gyuyoung Kim
Comment 5 2013-05-24 00:43:26 PDT
(In reply to comment #4) > (In reply to comment #2) > > (From update of attachment 202778 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=202778&action=review > > > > > Source/WebKit2/UIProcess/API/efl/ewk_security_origin.cpp:33 > > > #include <WebCore/SecurityOrigin.h> > > > > Could we remove this header include as well? > > Sure ! Oops. EFL WK2 EWS is pending now. There was no problem when I remove it on my local source.
Chris Dumez
Comment 6 2013-05-24 00:52:18 PDT
Comment on attachment 202779 [details] Patch Looks fine, r=me. Please make sure it builds locally before landing as the ews is sluggish today.
Gyuyoung Kim
Comment 7 2013-05-27 23:48:13 PDT
Comment on attachment 202779 [details] Patch Clearing flags on attachment: 202779 Committed r150787: <http://trac.webkit.org/changeset/150787>
Gyuyoung Kim
Comment 8 2013-05-27 23:48:20 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.