Summary: | [EFL][WK2] Remove unneeded WebCore namespace use in ewk | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Gyuyoung Kim <gyuyoung.kim> | ||||||
Component: | WebKit EFL | Assignee: | Gyuyoung Kim <gyuyoung.kim> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | cdumez, commit-queue, lucas.de.marchi, rakuco | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Gyuyoung Kim
2013-05-24 00:31:10 PDT
Created attachment 202778 [details]
Patch
Comment on attachment 202778 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=202778&action=review > Source/WebKit2/UIProcess/API/efl/ewk_security_origin.cpp:33 > #include <WebCore/SecurityOrigin.h> Could we remove this header include as well? Created attachment 202779 [details]
Patch
(In reply to comment #2) > (From update of attachment 202778 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=202778&action=review > > > Source/WebKit2/UIProcess/API/efl/ewk_security_origin.cpp:33 > > #include <WebCore/SecurityOrigin.h> > > Could we remove this header include as well? Sure ! (In reply to comment #4) > (In reply to comment #2) > > (From update of attachment 202778 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=202778&action=review > > > > > Source/WebKit2/UIProcess/API/efl/ewk_security_origin.cpp:33 > > > #include <WebCore/SecurityOrigin.h> > > > > Could we remove this header include as well? > > Sure ! Oops. EFL WK2 EWS is pending now. There was no problem when I remove it on my local source. Comment on attachment 202779 [details]
Patch
Looks fine, r=me. Please make sure it builds locally before landing as the ews is sluggish today.
Comment on attachment 202779 [details] Patch Clearing flags on attachment: 202779 Committed r150787: <http://trac.webkit.org/changeset/150787> All reviewed patches have been landed. Closing bug. |