Bug 116690

Summary: Don't run all plug-ins unsandboxed
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal CC: ossy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 116699    
Bug Blocks:    
Attachments:
Description Flags
Patch jberlin: review+

Anders Carlsson
Reported 2013-05-23 13:43:51 PDT
Don't run all plug-ins unsandboxed
Attachments
Patch (1.44 KB, patch)
2013-05-23 13:46 PDT, Anders Carlsson 		jberlin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2013-05-23 13:46:08 PDT
Created attachment 202739 [details] Patch
Anders Carlsson
Comment 2 2013-05-23 13:46:25 PDT
<rdar://problem/13975569>
Anders Carlsson
Comment 3 2013-05-23 13:48:26 PDT
Committed r150610: <http://trac.webkit.org/changeset/150610>
Csaba Osztrogonác
Comment 4 2013-05-23 21:53:20 PDT
(In reply to comment #3) > Committed r150610: <http://trac.webkit.org/changeset/150610> It broke the build on Qt because of a serious warning: /ramdisk/qt-linux-32-release-webkit2/build/Source/WebKit2/UIProcess/WebPageProxy.cpp: In member function 'void WebKit::WebPageProxy::findPlugin(const WTF::String&, uint32_t, const WTF::String&, const WTF::String&, const WTF::String&, bool, uint64_t&, WTF::String&, uint32_t&)': /ramdisk/qt-linux-32-release-webkit2/build/Source/WebKit2/UIProcess/WebPageProxy.cpp:1440:155: error: 'pluginProcessSandboxPolicy' may be used uninitialized in this function [-Werror=uninitialized] I think pluginProcessSandboxPolicy should be always initialized, but it isn't if pluginLoadPolicy is pluginModuleBlocked or pluginModuleInactive. Could you fix it, please?
Csaba Osztrogonác
Comment 5 2013-05-23 22:02:00 PDT
new bug report for it - https://bugs.webkit.org/show_bug.cgi?id=116699
Note You need to log in before you can comment on or make changes to this bug.