Bug 116679

Summary: Refactoring CSS grammar
Product: WebKit Reporter: Sergio Villar Senin <svillar>
Component: CSSAssignee: Sergio Villar Senin <svillar>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, csaavedra, darin, glenn, kling, svillar, syoichi
Priority: P2 Keywords: BlinkMergeCandidate
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 115709    
Bug Blocks: 116071    
Attachments:
Description Flags
Patch none

Sergio Villar Senin
Reported 2013-05-23 09:00:39 PDT
We should probably merge https://chromium.googlesource.com/chromium/blink/+/959863e444241eb36cff89d2c956676cd468bddf Nonfunctional change. Introduced closing_parenthesis and error_recovery to reduce code duplication. Extracted from https://codereview.chromium.org/14969002/
Attachments
Patch (3.93 KB, patch)
2013-05-28 03:36 PDT, Sergio Villar Senin 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Sergio Villar Senin
Comment 1 2013-05-23 09:40:21 PDT
Which seems to depend on https://codereview.chromium.org/14083017.
Sergio Villar Senin
Comment 2 2013-05-28 03:36:52 PDT
Created attachment 203036 [details] Patch
Sergio Villar Senin
Comment 3 2013-05-28 07:37:25 PDT
Comment on attachment 203036 [details] Patch Clearing flags on attachment: 203036 Committed r150804: <http://trac.webkit.org/changeset/150804>
Sergio Villar Senin
Comment 4 2013-05-28 07:37:32 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.