Bug 116679

Summary:

Refactoring CSS grammar

Product:

WebKit

Reporter:

Sergio Villar Senin <svillar>

Component:

CSS

Assignee:

Sergio Villar Senin <svillar>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, csaavedra, darin, glenn, kling, svillar, syoichi

Priority:

Keywords:

BlinkMergeCandidate

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

115709

Bug Blocks:

116071

Attachments:

Description	Flags
Patch	none

Description Sergio Villar Senin 2013-05-23 09:00:39 PDT

We should probably merge
https://chromium.googlesource.com/chromium/blink/+/959863e444241eb36cff89d2c956676cd468bddf

Nonfunctional change.
Introduced closing_parenthesis and error_recovery to reduce code duplication.

Extracted from https://codereview.chromium.org/14969002/

Comment 1 Sergio Villar Senin 2013-05-23 09:40:21 PDT

Which seems to depend on https://codereview.chromium.org/14083017.

Comment 2 Sergio Villar Senin 2013-05-28 03:36:52 PDT

Created attachment 203036 [details]
Patch

Comment 3 Sergio Villar Senin 2013-05-28 07:37:25 PDT

Comment on attachment 203036 [details]
Patch

Clearing flags on attachment: 203036

Committed r150804: <http://trac.webkit.org/changeset/150804>

Comment 4 Sergio Villar Senin 2013-05-28 07:37:32 PDT

All reviewed patches have been landed.  Closing bug.