Bug 116678
| Summary: | CSS Variables tokenisation not checking CSS identifier length | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Sergio Villar Senin <svillar> |
| Component: | CSS | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED INVALID | ||
| Severity: | Normal | CC: | alancutter, glenn, svillar, syoichi |
| Priority: | P2 | Keywords: | BlinkMergeCandidate |
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | 116071 | ||
| Bug Blocks: | |||
Sergio Villar Senin
We should consider merging this change https://codereview.chromium.org/15317009 and the test case which is not currently in WebKit.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Sergio Villar Senin
There is no need to merge this fix. The ASSERT() was triggered because the code was using isEqualToCSSIdentifier() which had some restrictions not applicable to the CSS variables case. Actually the ASSERT() mentioned in the Chromium bug can no longer happen since r150776, as we perform a case sensitive check in a different inline method which does not have those assertions.