Bug 116674

Summary: [BlackBerry] Validate form data before doing direct submission.
Product: WebKit Reporter: Mike Fenton <mifenton>
Component: WebKit BlackBerryAssignee: Mike Fenton <mifenton>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Validation patch.
xan.lopez: review-
tabIndex patch
none
Updated Patch none

Mike Fenton
Reported 2013-05-23 07:26:13 PDT
Two fixes: 1) Improve the submission trigger to validate the form. 2) Respect TabIndex when calculating next/prev elements.
Attachments
Validation patch. (2.69 KB, patch)
2013-05-23 07:30 PDT, Mike Fenton 		xan.lopez: review-
DetailsFormatted DiffDiff
tabIndex patch (9.59 KB, patch)
2013-05-23 07:31 PDT, Mike Fenton 		no flags
DetailsFormatted DiffDiff
Updated Patch (2.70 KB, patch)
2013-05-23 08:10 PDT, Mike Fenton 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Mike Fenton
Comment 1 2013-05-23 07:30:37 PDT
Created attachment 202711 [details] Validation patch.
Mike Fenton
Comment 2 2013-05-23 07:31:21 PDT
Created attachment 202712 [details] tabIndex patch
Mike Fenton
Comment 3 2013-05-23 08:04:32 PDT
Comment on attachment 202712 [details] tabIndex patch Clearing flags, moved to new bug 116676.
Xan Lopez
Comment 4 2013-05-23 08:06:27 PDT
Comment on attachment 202711 [details] Validation patch. View in context: https://bugs.webkit.org/attachment.cgi?id=202711&action=review > Source/WebKit/blackberry/ChangeLog:3 > + [BlackBerry] Improve input form control handling. We should do one patch per bug. I suggest we rename this to something related to form validation, and move the other patch elsewhere. > Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp:1022 > + formElement->submit(); Makes sense to me otherwise, seems it just moves code around to check validity before doing submit(). So please rename the title to land it!
Mike Fenton
Comment 5 2013-05-23 08:10:07 PDT
Created attachment 202716 [details] Updated Patch
Xan Lopez
Comment 6 2013-05-23 08:12:21 PDT
Comment on attachment 202716 [details] Updated Patch r=me
WebKit Commit Bot
Comment 7 2013-05-23 08:54:56 PDT
Comment on attachment 202716 [details] Updated Patch Clearing flags on attachment: 202716 Committed r150587: <http://trac.webkit.org/changeset/150587>
WebKit Commit Bot
Comment 8 2013-05-23 08:54:58 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.