Summary: | [BlackBerry] Validate form data before doing direct submission. | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Mike Fenton <mifenton> | ||||||||
Component: | WebKit BlackBerry | Assignee: | Mike Fenton <mifenton> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | commit-queue | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Mike Fenton
2013-05-23 07:26:13 PDT
Created attachment 202711 [details]
Validation patch.
Created attachment 202712 [details]
tabIndex patch
Comment on attachment 202712 [details] tabIndex patch Clearing flags, moved to new bug 116676. Comment on attachment 202711 [details] Validation patch. View in context: https://bugs.webkit.org/attachment.cgi?id=202711&action=review > Source/WebKit/blackberry/ChangeLog:3 > + [BlackBerry] Improve input form control handling. We should do one patch per bug. I suggest we rename this to something related to form validation, and move the other patch elsewhere. > Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp:1022 > + formElement->submit(); Makes sense to me otherwise, seems it just moves code around to check validity before doing submit(). So please rename the title to land it! Created attachment 202716 [details]
Updated Patch
Comment on attachment 202716 [details]
Updated Patch
r=me
Comment on attachment 202716 [details] Updated Patch Clearing flags on attachment: 202716 Committed r150587: <http://trac.webkit.org/changeset/150587> All reviewed patches have been landed. Closing bug. |