Bug 116666

Summary: [CMake] Add generation of JITStubs for x86_64 MSVC
Product: WebKit Reporter: Patrick R. Gansterer <paroga>
Component: JavaScriptCoreAssignee: Patrick R. Gansterer <paroga>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, gyuyoung.kim, rakuco
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch laszlo.gombos: review+

Patrick R. Gansterer
Reported 2013-05-23 06:13:48 PDT
[CMake] Add generation of JITStubs for x86_64 MSVC
Attachments
Patch (3.47 KB, patch)
2013-05-23 06:17 PDT, Patrick R. Gansterer 		laszlo.gombos: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Patrick R. Gansterer
Comment 1 2013-05-23 06:17:47 PDT
Created attachment 202702 [details] Patch
Build Bot
Comment 2 2013-05-23 06:52:58 PDT
Comment on attachment 202702 [details] Patch Attachment 202702 [details] did not pass win-ews (win): Output: http://webkit-queues.appspot.com/results/639092
Laszlo Gombos
Comment 3 2013-06-20 11:39:29 PDT
Comment on attachment 202702 [details] Patch Lets try to run EWS again..
Laszlo Gombos
Comment 4 2013-06-20 11:44:33 PDT
Comment on attachment 202702 [details] Patch This looks good to me. Please make sure the win EWS failure is unrelated before committing. We should continue to discuss the usage of WTF_CPU_XXX CMake variables at bug 116662 .
Raphael Kubo da Costa (:rakuco)
Comment 5 2013-06-20 11:50:52 PDT
Comment on attachment 202702 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=202702&action=review > Source/JavaScriptCore/ChangeLog:9 > + since it's compiler specific and not dedecated to Windwos CE. nitpick: dedecated -> dedicated, Windwos -> Windows.
Patrick R. Gansterer
Comment 6 2013-07-04 02:16:57 PDT
Committed r152395: <http://trac.webkit.org/changeset/152395>
Note You need to log in before you can comment on or make changes to this bug.