Bug 116660

Summary: Remove [NoInterfaceObject] from FileReaderSync and WorkerLocation
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: BindingsAssignee: Chris Dumez <cdumez>
Status: RESOLVED LATER    
Severity: Normal CC: ap, benjamin, commit-queue, esprehn+autocc, gyuyoung.kim, haraken, laszlo.gombos, rakuco, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 116708    
Bug Blocks: 115853    
Attachments:
Description Flags
Patch none

Chris Dumez
Reported 2013-05-23 05:05:03 PDT
According to their respective specs, FileReaderSync and WorkerLocation should not have [NoInterfaceObject] IDL extended attribute: http://dev.w3.org/2006/webapi/FileAPI/#FileReaderSync http://dev.w3.org/html5/workers/#workerlocation This is blocking Bug 115853 as these interfaces have constructors on the WorkerContext object.
Attachments
Patch (17.69 KB, patch)
2013-05-23 06:52 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2013-05-23 06:52:50 PDT
Created attachment 202703 [details] Patch
Kentaro Hara
Comment 2 2013-05-23 07:00:14 PDT
Comment on attachment 202703 [details] Patch looks ok
WebKit Commit Bot
Comment 3 2013-05-23 08:19:54 PDT
Comment on attachment 202703 [details] Patch Clearing flags on attachment: 202703 Committed r150586: <http://trac.webkit.org/changeset/150586>
WebKit Commit Bot
Comment 4 2013-05-23 08:19:59 PDT
All reviewed patches have been landed. Closing bug.
Chris Dumez
Comment 5 2013-05-23 09:44:59 PDT
Reverted r150586 for reason: Those constructors should be exposed on the WorkerContext, not the DOMWindow Committed r150590: <http://trac.webkit.org/changeset/150590>
Chris Dumez
Comment 6 2013-06-04 01:01:57 PDT
Those will be removed once we automatically generate WorkerContext constructor attributes.
Note You need to log in before you can comment on or make changes to this bug.