Bug 116653

Summary: Remove special case for MessagePortArray from bindings generator
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: BindingsAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: alecflett, ap, benjamin, commit-queue, esprehn+autocc, haraken, jsbell, laszlo.gombos, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
URL: http://dev.w3.org/html5/postmsg/#event-definitions
Attachments:
Description Flags
Patch none

Chris Dumez
Reported 2013-05-23 00:51:09 PDT
We should use MessagePort[] instead of MessagePortArray in the IDL to match the spec and avoid special casing in the bindings generator.
Attachments
Patch (16.53 KB, patch)
2013-05-23 03:35 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2013-05-23 03:35:10 PDT
Created attachment 202655 [details] Patch
Kentaro Hara
Comment 2 2013-05-23 04:05:09 PDT
Comment on attachment 202655 [details] Patch Looks good. Nit: Should we use MessagePort[] or sequence<MessagePort>?
Chris Dumez
Comment 3 2013-05-23 04:07:26 PDT
(In reply to comment #2) > (From update of attachment 202655 [details]) > Looks good. > > Nit: Should we use MessagePort[] or sequence<MessagePort>? http://dev.w3.org/html5/postmsg/#event-definitions says MessagePort[]? but I did not make it nullable as I did not want to change the behavior in this patch. FYI, preparing a similar patch for Blink.
Kentaro Hara
Comment 4 2013-05-23 04:08:23 PDT
OK, let's go with MessagePort[] :)
WebKit Commit Bot
Comment 5 2013-05-23 05:22:04 PDT
Comment on attachment 202655 [details] Patch Clearing flags on attachment: 202655 Committed r150580: <http://trac.webkit.org/changeset/150580>
WebKit Commit Bot
Comment 6 2013-05-23 05:22:07 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.