Bug 116639

Summary: Fix assertion in the getComputedStyle-background-shorthand.html test
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch rniwa: review+

Description Simon Fraser (smfr) 2013-05-22 15:08:59 PDT
Fix assertion in the getComputedStyle-background-shorthand.html test
Comment 1 Simon Fraser (smfr) 2013-05-22 15:13:15 PDT
Created attachment 202627 [details]
Patch
Comment 2 Ryosuke Niwa 2013-05-22 15:16:21 PDT
Comment on attachment 202627 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=202627&action=review

> Source/WebCore/rendering/RenderObject.cpp:2527
> +    if (!isText()) {

I wish we had a way to assert that this is the only case we have to worry about.
Comment 3 Simon Fraser (smfr) 2013-05-22 15:19:20 PDT
https://trac.webkit.org/r150547