Bug 116639

Summary: Fix assertion in the getComputedStyle-background-shorthand.html test
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch rniwa: review+

Simon Fraser (smfr)
Reported 2013-05-22 15:08:59 PDT
Fix assertion in the getComputedStyle-background-shorthand.html test
Attachments
Patch (2.51 KB, patch)
2013-05-22 15:13 PDT, Simon Fraser (smfr) 		rniwa: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2013-05-22 15:13:15 PDT
Created attachment 202627 [details] Patch
Ryosuke Niwa
Comment 2 2013-05-22 15:16:21 PDT
Comment on attachment 202627 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=202627&action=review > Source/WebCore/rendering/RenderObject.cpp:2527 > + if (!isText()) { I wish we had a way to assert that this is the only case we have to worry about.
Simon Fraser (smfr)
Comment 3 2013-05-22 15:19:20 PDT
https://trac.webkit.org/r150547
Note You need to log in before you can comment on or make changes to this bug.