Bug 116603

Summary: [BlackBerry] Properly fill the ResourceError in FrameLoaderClientBlackBerry::cannotShowURLError
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebKit BlackBerryAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, rwlbuis, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 111729    
Attachments:
Description Flags
Patch none

Description Carlos Garcia Campos 2013-05-22 02:57:29 PDT
It's passing an empty error domain
Comment 1 Carlos Garcia Campos 2013-05-22 03:01:00 PDT
Created attachment 202513 [details]
Patch
Comment 2 Xan Lopez 2013-05-22 03:23:38 PDT
Comment on attachment 202513 [details]
Patch

To be honest I don't know what's the effect of this, although the ChangeLog literally says there's no change in behavior. Are these strings picked up by someone above WebKit? It would be good to mention it in the ChangeLog.
Comment 3 Carlos Garcia Campos 2013-05-23 03:52:46 PDT
(In reply to comment #2)
> (From update of attachment 202513 [details])
> To be honest I don't know what's the effect of this, although the ChangeLog literally says there's no change in behavior. Are these strings picked up by someone above WebKit? It would be good to mention it in the ChangeLog.

This is an internal commit made by Rob, I think it's pretty obvious that we were passing an empty string to the Error and now we are passing a valid error domain. I guess he meant that this doesn't affect any test, because it simply provides a valid error domain, it's up to the api consumers to use that domain or not.
Comment 4 Xan Lopez 2013-05-23 06:29:54 PDT
Comment on attachment 202513 [details]
Patch

OK. I was a bit confused because I didn't get why we would put there a FIXME instead of putting whatever error domain fits better, was wondering if there was something more subtle at play here.
Comment 5 WebKit Commit Bot 2013-05-23 07:14:33 PDT
Comment on attachment 202513 [details]
Patch

Clearing flags on attachment: 202513

Committed r150585: <http://trac.webkit.org/changeset/150585>
Comment 6 WebKit Commit Bot 2013-05-23 07:14:36 PDT
All reviewed patches have been landed.  Closing bug.