Bug 116591

Summary:

Fix issues with focus rings on search fields

Product:

WebKit

Reporter:

Simon Fraser (smfr) <simon.fraser>

Component:

New Bugs

Assignee:

Simon Fraser (smfr) <simon.fraser>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bdakin, simon.fraser, thorton

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	darin: review+

Description Simon Fraser (smfr) 2013-05-21 22:30:48 PDT

Fix issues with focus rings on search fields

Comment 1 Simon Fraser (smfr) 2013-05-21 22:35:49 PDT

Created attachment 202498 [details]
Patch

Comment 2 Darin Adler 2013-05-22 07:46:04 PDT

Comment on attachment 202498 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=202498&action=review

> Source/WebKit/mac/WebView/WebHTMLView.mm:4953
> +    // Required to fix search field focus rings <rdar://problem/13780122>.

The use of "fix" here is not clear enough. It would be better if this comment was more specific about what exactly AppKit does when we return YES here that helps us. I tried to read your comment in the change log, but I couldn’t understand it.

Comment 3 Simon Fraser (smfr) 2013-05-22 12:06:45 PDT

https://trac.webkit.org/r150530