Summary: | Fix Windows build | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Sam Weinig <sam> | ||||||||||
Component: | Platform | Assignee: | Nobody <webkit-unassigned> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | ||||||||||||
Priority: | P2 | ||||||||||||
Version: | 420+ | ||||||||||||
Hardware: | PC | ||||||||||||
OS: | Windows XP | ||||||||||||
Attachments: |
|
Description
Sam Weinig
2006-11-20 09:26:15 PST
Created attachment 11582 [details]
patch
Created attachment 11583 [details]
updated patch
Updated patch. Now uses correct line ending for .vcproj file.
Comment on attachment 11583 [details]
updated patch
r=me
Comment on attachment 11583 [details]
updated patch
Make sure to change the include directories in both debug and release sections, or there will be weird issues down the road.
Otherwise looks good.
Created attachment 11585 [details]
patch 3
Fixed.
Comment on attachment 11585 [details]
patch 3
Nit: The "release" #include dir change line is indented using spaces instead of tabs. Fix to use tabs like the debug one does (.vcprojs use tabs).
With that fixed, r=me
Created attachment 11586 [details]
patch the forth
fixed tabs
|