Bug 11656

Summary: Fix Windows build
Product: WebKit Reporter: Sam Weinig <sam>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 420+   
Hardware: PC   
OS: Windows XP   
Attachments:
Description Flags
patch
none
updated patch
dgibson77: review-
patch 3
dgibson77: review+
patch the forth none

Description Sam Weinig 2006-11-20 09:26:15 PST
Patch to update code forthcoming.
Comment 1 Sam Weinig 2006-11-20 09:29:30 PST
Created attachment 11582 [details]
patch
Comment 2 Sam Weinig 2006-11-20 10:32:50 PST
Created attachment 11583 [details]
updated patch

Updated patch.  Now uses correct line ending for .vcproj file.
Comment 3 Alexey Proskuryakov 2006-11-20 10:37:06 PST
Comment on attachment 11583 [details]
updated patch

r=me
Comment 4 Don Gibson 2006-11-20 10:39:10 PST
Comment on attachment 11583 [details]
updated patch

Make sure to change the include directories in both debug and release sections, or there will be weird issues down the road.

Otherwise looks good.
Comment 5 Sam Weinig 2006-11-20 10:54:07 PST
Created attachment 11585 [details]
patch 3

Fixed.
Comment 6 Don Gibson 2006-11-20 11:27:57 PST
Comment on attachment 11585 [details]
patch 3

Nit: The "release" #include dir change line is indented using spaces instead of tabs.  Fix to use tabs like the debug one does (.vcprojs use tabs).

With that fixed, r=me
Comment 7 Sam Weinig 2006-11-20 12:03:04 PST
Created attachment 11586 [details]
patch the forth

fixed tabs
Comment 8 Mark Rowe (bdash) 2006-11-20 12:08:25 PST
Landed in r17861.