Bug 11656 - Fix Windows build
Summary: Fix Windows build
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 420+
Hardware: PC Windows XP
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-11-20 09:26 PST by Sam Weinig
Modified: 2006-11-20 12:08 PST (History)
0 users

See Also:

Attachments
patch (31.24 KB, patch)
2006-11-20 09:29 PST, Sam Weinig 		no flags Details | Formatted Diff | Diff
updated patch (11.79 KB, patch)
2006-11-20 10:32 PST, Sam Weinig 		dgibson77: review-
Details | Formatted Diff | Diff
patch 3 (14.90 KB, patch)
2006-11-20 10:54 PST, Sam Weinig 		dgibson77: review+
Details | Formatted Diff | Diff
patch the forth (14.89 KB, patch)
2006-11-20 12:03 PST, Sam Weinig 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2006-11-20 09:26:15 PST 
Patch to update code forthcoming.
Comment 1 Sam Weinig 2006-11-20 09:29:30 PST 
Created attachment 11582 [details]
patch
Comment 2 Sam Weinig 2006-11-20 10:32:50 PST 
Created attachment 11583 [details]
updated patch

Updated patch.  Now uses correct line ending for .vcproj file.
Comment 3 Alexey Proskuryakov 2006-11-20 10:37:06 PST 
Comment on attachment 11583 [details]
updated patch

r=me
Comment 4 Don Gibson 2006-11-20 10:39:10 PST 
Comment on attachment 11583 [details]
updated patch

Make sure to change the include directories in both debug and release sections, or there will be weird issues down the road.

Otherwise looks good.
Comment 5 Sam Weinig 2006-11-20 10:54:07 PST 
Created attachment 11585 [details]
patch 3

Fixed.
Comment 6 Don Gibson 2006-11-20 11:27:57 PST 
Comment on attachment 11585 [details]
patch 3

Nit: The "release" #include dir change line is indented using spaces instead of tabs.  Fix to use tabs like the debug one does (.vcprojs use tabs).

With that fixed, r=me
Comment 7 Sam Weinig 2006-11-20 12:03:04 PST 
Created attachment 11586 [details]
patch the forth

fixed tabs
Comment 8 Mark Rowe (bdash) 2006-11-20 12:08:25 PST 
Landed in r17861.