Bug 116532

Summary:

Allow session storage for third-party origins even if third-party data access is blocked.

Product:

WebKit

Reporter:

Andy Estes <aestes>

Component:

DOM

Assignee:

Andy Estes <aestes>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ddkilzer, jeffrey+webkit, kobi.co, mjs, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	andersca: review+

Description Andy Estes 2013-05-21 05:48:04 PDT

Allow session storage for third-party origins even if tthird-party data access is blocked.

Comment 1 Andy Estes 2013-05-21 05:50:03 PDT

<rdar://problem/13921879>

Comment 2 Andy Estes 2013-05-21 06:05:22 PDT

Created attachment 202420 [details]
Patch

Comment 3 Anders Carlsson 2013-05-21 15:38:25 PDT

Comment on attachment 202420 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=202420&action=review

> Source/WebCore/page/SecurityOrigin.cpp:401
> +    return (m_storageBlockingPolicy == AllowAllStorage && topOrigin->m_storageBlockingPolicy == AllowAllStorage)
> +        || shouldAllowFromThirdParty == AlwaysAllowFromThirdParty
> +        || !topOrigin->isThirdParty(this);

I think this would be easier to understand as multiple early returns.

Comment 4 Andy Estes 2013-05-21 17:02:55 PDT

Committed r150490: <http://trac.webkit.org/changeset/150490>

Comment 5 Andy Estes 2013-05-21 17:07:53 PDT

Oops, I forgot to 'git add' the new layout test and its expected result. Fixed in <http://trac.webkit.org/changeset/150492>.