Bug 116520

Summary: Have IDL interface names match their global constructor
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: BindingsAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, benjamin, buildbot, commit-queue, eric.carlson, esprehn+autocc, ggaren, glenn, gyuyoung.kim, haraken, hta, jer.noble, laszlo.gombos, rakuco, rniwa, tommyw
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
URL: http://dev.w3.org/2006/webapi/WebIDL/#es-interfaces
Bug Depends on:    
Bug Blocks: 115853    
Attachments:
Description Flags
WIP Patch
buildbot: commit-queue-
Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2
none
Patch none

Chris Dumez
Reported 2013-05-21 00:55:42 PDT
There are currently several IDL interfaces whose name doesn't match their global constructor attribute on DOMWindow.idl. As a result, those cannot be automatically generated. This currently forces us to mark those interfaces as [NoInterfaceObject] which is incorrect and not according to spec.
Attachments
WIP Patch (22.40 KB, patch)
2013-05-21 01:05 PDT, Chris Dumez 		buildbot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2 (680.51 KB, application/zip)
2013-05-21 17:24 PDT, Build Bot 		no flags
Details
Patch (11.57 KB, patch)
2013-05-22 04:24 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2013-05-21 01:05:13 PDT
Created attachment 202396 [details] WIP Patch
Build Bot
Comment 2 2013-05-21 17:24:12 PDT
Comment on attachment 202396 [details] WIP Patch Attachment 202396 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/524290 New failing tests: fast/js/global-constructors-attributes.html
Build Bot
Comment 3 2013-05-21 17:24:14 PDT
Created attachment 202482 [details] Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-09 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.3
Chris Dumez
Comment 4 2013-05-22 04:24:43 PDT
Created attachment 202521 [details] Patch
Kentaro Hara
Comment 5 2013-05-22 04:30:12 PDT
Comment on attachment 202521 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=202521&action=review Looks OK. > Source/WebCore/Modules/mediastream/MediaStream.idl:32 > + SkipVTableValidation, BTW, I think you can remove [SkipVTableValidation]. [ImplementationLacksVTable] and [ImplementationNamespace]. They were used in V8 binding only.
Chris Dumez
Comment 6 2013-05-22 04:33:34 PDT
Comment on attachment 202521 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=202521&action=review >> Source/WebCore/Modules/mediastream/MediaStream.idl:32 >> + SkipVTableValidation, > > BTW, I think you can remove [SkipVTableValidation]. [ImplementationLacksVTable] and [ImplementationNamespace]. They were used in V8 binding only. I quickly grep'd and it seems all 3 are used by the JSC bindings generator.
WebKit Commit Bot
Comment 7 2013-05-22 05:04:11 PDT
Comment on attachment 202521 [details] Patch Clearing flags on attachment: 202521 Committed r150509: <http://trac.webkit.org/changeset/150509>
WebKit Commit Bot
Comment 8 2013-05-22 05:04:16 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.