Summary: | Have IDL interface names match their global constructor | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||||
Component: | Bindings | Assignee: | Chris Dumez <cdumez> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | ap, benjamin, buildbot, commit-queue, eric.carlson, esprehn+autocc, ggaren, glenn, gyuyoung.kim, haraken, hta, jer.noble, laszlo.gombos, rakuco, rniwa, tommyw | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
URL: | http://dev.w3.org/2006/webapi/WebIDL/#es-interfaces | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 115853 | ||||||||||
Attachments: |
|
Description
Chris Dumez
2013-05-21 00:55:42 PDT
Created attachment 202396 [details]
WIP Patch
Comment on attachment 202396 [details] WIP Patch Attachment 202396 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/524290 New failing tests: fast/js/global-constructors-attributes.html Created attachment 202482 [details]
Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-09 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.3
Created attachment 202521 [details]
Patch
Comment on attachment 202521 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=202521&action=review Looks OK. > Source/WebCore/Modules/mediastream/MediaStream.idl:32 > + SkipVTableValidation, BTW, I think you can remove [SkipVTableValidation]. [ImplementationLacksVTable] and [ImplementationNamespace]. They were used in V8 binding only. Comment on attachment 202521 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=202521&action=review >> Source/WebCore/Modules/mediastream/MediaStream.idl:32 >> + SkipVTableValidation, > > BTW, I think you can remove [SkipVTableValidation]. [ImplementationLacksVTable] and [ImplementationNamespace]. They were used in V8 binding only. I quickly grep'd and it seems all 3 are used by the JSC bindings generator. Comment on attachment 202521 [details] Patch Clearing flags on attachment: 202521 Committed r150509: <http://trac.webkit.org/changeset/150509> All reviewed patches have been landed. Closing bug. |