Bug 116516

Summary: REGRESSION(r150393): editing/inserting/typing-at-end-of-line.html fails
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: HTML EditingAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 116573    
Bug Blocks:    
Attachments:
Description Flags
Fixes the bug
none
Fixes DRT ap: review+

Ryosuke Niwa
Reported 2013-05-20 23:16:29 PDT
REGRESSION(r150393): editing/inserting/typing-at-end-of-line.html
Attachments
Fixes the bug (2.10 KB, patch)
2013-05-21 00:36 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Fixes DRT (2.11 KB, patch)
2013-05-21 14:23 PDT, Ryosuke Niwa 		ap: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2013-05-21 00:36:56 PDT
Created attachment 202389 [details] Fixes the bug
Ryosuke Niwa
Comment 2 2013-05-21 00:38:50 PDT
Committed r150425: <http://trac.webkit.org/changeset/150425>
WebKit Commit Bot
Comment 3 2013-05-21 13:40:40 PDT
Re-opened since this is blocked by bug 116573
Ryosuke Niwa
Comment 4 2013-05-21 14:23:31 PDT
Created attachment 202470 [details] Fixes DRT
Alexey Proskuryakov
Comment 5 2013-05-21 14:25:17 PDT
Comment on attachment 202470 [details] Fixes DRT View in context: https://bugs.webkit.org/attachment.cgi?id=202470&action=review > Tools/DumpRenderTree/mac/DumpRenderTree.mm:549 > - [webView setDefersCallbacks:NO]; > [webView setGrammarCheckingEnabled:YES]; > + > + [webView setDefersCallbacks:NO]; Why this change?
Ryosuke Niwa
Comment 6 2013-05-21 14:26:42 PDT
Comment on attachment 202470 [details] Fixes DRT View in context: https://bugs.webkit.org/attachment.cgi?id=202470&action=review >> Tools/DumpRenderTree/mac/DumpRenderTree.mm:549 >> + [webView setDefersCallbacks:NO]; > > Why this change? I matched the ordering.
Ryosuke Niwa
Comment 7 2013-05-21 14:27:34 PDT
Committed r150479: <http://trac.webkit.org/changeset/150479>
Note You need to log in before you can comment on or make changes to this bug.