Bug 116474

Summary: check-webkit-style should not warn about use of C++11 “>>” instead of “> >"
Product: WebKit Reporter: Jessie Berlin <jberlin>
Component: Tools / TestsAssignee: Jessie Berlin <jberlin>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, ap, commit-queue, dpranke, glenn, psolanki, rniwa, sam, thorton, tonikitoo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Jessie Berlin 2013-05-20 16:12:59 PDT
Right now it spits out the following warning:

Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp:719:  Missing spaces around >>  [whitespace/operators] [3]

for a line like

void WebChromeClient::didAssociateFormControls(const Vector<RefPtr<WebCore::Element>>& elements)

It shouldn’t, since we are using C++11 in WK2.
Comment 1 Sam Weinig 2013-09-19 18:10:32 PDT
Created attachment 212112 [details]
Patch
Comment 2 Sam Weinig 2013-09-30 21:11:40 PDT
Created attachment 213052 [details]
Patch
Comment 3 Ryosuke Niwa 2013-09-30 21:20:39 PDT
Wrong bug?
Comment 4 Sam Weinig 2013-09-30 21:25:06 PDT
(In reply to comment #3)
> Wrong bug?

Yup :(.
Comment 5 WebKit Commit Bot 2013-09-30 21:56:34 PDT
Comment on attachment 212112 [details]
Patch

Clearing flags on attachment: 212112

Committed r156694: <http://trac.webkit.org/changeset/156694>
Comment 6 WebKit Commit Bot 2013-09-30 21:56:37 PDT
All reviewed patches have been landed.  Closing bug.