Bug 116473 – REGRESSION(r150354): editing/selection/user-drag-element-and-user-select-none.html

• Component: HTML Editing
• Status: NEW

[Ryosuke Niwa]

e.g.
http://build.webkit.org/results/Apple%20MountainLion%20Release%20WK1%20(Tests)/r150354%20(10119)/results.html

Pass: http://build.webkit.org/builders/Apple%20MountainLion%20Release%20WK1%20%28Tests%29/builds/10118
Fail: http://build.webkit.org/builders/Apple%20MountainLion%20Release%20WK1%20%28Tests%29/builds/10119

[Ryosuke Niwa]

--- /Volumes/Data/slave/mountainlion-release-tests-wk1/build/layout-test-results/editing/selection/user-drag-element-and-user-select-none-expected.txt
+++ /Volumes/Data/slave/mountainlion-release-tests-wk1/build/layout-test-results/editing/selection/user-drag-element-and-user-select-none-actual.txt
@@ -1,12 +1,12 @@
 Test for WebKit bug 15106: Dragging text inside an element with "user-drag: element" and "user-select: none" should initiate a drag
 
-SUCCESS Expected '3' and got it.
+FAIL Expected '3' but got '6'.
 
 SUCCESS Expected 'mousedown' and got it.
 
-SUCCESS Expected 'mouseup' and got it.
+FAIL Expected 'mouseup' but got 'dragstart'.
 
-SUCCESS Expected 'Selection' and got it.
+FAIL Expected 'Selection' but got 'mouseup'.
 
 This element should be draggable, but initiating a drag from within the text should begin a selection.
 SUCCESS Expected '3' and got it.

[Ryosuke Niwa]

It’s failing on all platforms:
http://webkit-test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=editing%2Fselection%2Fuser-drag-element-and-user-select-none.html

[Ryosuke Niwa]

Added a test expectation in http://trac.webkit.org/changeset/150385.

[Darin Adler]

Oops. I’ll fix this soon. Probably just need to use innerNode and walk the parent chain instead of using innerElement.

[Darin Adler]

I don’t know what to do here. I can’t reproduce this locally on my Mountain Lion computer.

[Ryosuke Niwa]

(In reply to comment #5)
> I don’t know what to do here. I can’t reproduce this locally on my Mountain Lion computer.

Did you remove or comment out the entry in LayoutTests/Expectations? As confusing as it is, --force doesn't make NRWT ignore test expectations.

[Ryosuke Niwa]

i.e.

Index: LayoutTests/TestExpectations
===================================================================
--- LayoutTests/TestExpectations	(revision 150727)
+++ LayoutTests/TestExpectations	(working copy)
@@ -14,7 +14,7 @@
 # media/video-seek-after-end.html is flaky
 webkit.org/b/116293 media/video-seek-after-end.html [ Pass Failure ]
 
-webkit.org/b/116473 editing/selection/user-drag-element-and-user-select-none.html [ Failure ]
+# webkit.org/b/116473 editing/selection/user-drag-element-and-user-select-none.html [ Failure ]
 
 # media/W3C/video/networkState/networkState_during_progress.html is flaky
 webkit.org/b/76280 media/W3C/video/networkState/networkState_during_progress.html [ Pass Failure ]

With that, I can reproduce the failure locally.

[Darin Adler]

Yes, I removed that line.