|Summary:||PLATFORM(*) macros used in Source/WebCore/loader/archive/ArchiveFactory.cpp|
|Product:||WebKit||Reporter:||Zan Dobersek <zan>|
|Component:||WebCore Misc.||Assignee:||Zan Dobersek <zan>|
|Severity:||Normal||CC:||ap, commit-queue, japhet|
|Version:||528+ (Nightly build)|
|Bug Depends on:|
Description Zan Dobersek 2013-05-20 11:42:22 PDT
There's a couple of PLATFORM(*) macros used in ArchiveFactory.cpp, specifying which mime types are supported on what platform. http://trac.webkit.org/browser/trunk/Source/WebCore/loader/archive/ArchiveFactory.cpp#L58 This should be moved into the platform layer.
Comment 1 Alexey Proskuryakov 2013-05-20 16:03:10 PDT
Can you please elaborate on the reason? Note that platform directory contains the "platform" on which WebCore builds. While much of that is platform specific, keeping platforms specific code together in one place is not the reason for its existence.
Comment 2 Zan Dobersek 2013-05-20 23:32:54 PDT
I've filed this due to the layering violation reported by the check-webkit-style script in bug #116442. https://bugs.webkit.org/show_bug.cgi?id=116442#c2 The patch took on a different path later, removing most of the PLATFORM macros in r150418. http://trac.webkit.org/changeset/150418 There's still one PLATFORM(QT) left in the file: http://trac.webkit.org/browser/trunk/Source/WebCore/loader/archive/ArchiveFactory.cpp#L34 I think it can be removed because the Qt port does not enable WebArchive support even when using CoreFoundations.
Comment 4 Alexey Proskuryakov 2013-05-21 08:29:25 PDT
Comment on attachment 202381 [details] Patch I think that the style bot is wrong complaining about this. Do you know when the check was added? r=me on this change.
Comment 5 Zan Dobersek 2013-05-21 08:45:06 PDT
That would be r149635. http://trac.webkit.org/changeset/149635
Comment 6 Zan Dobersek 2013-05-21 09:02:41 PDT
Comment on attachment 202381 [details] Patch Clearing flags on attachment: 202381 Committed r150444: <http://trac.webkit.org/changeset/150444>
Comment 7 Zan Dobersek 2013-05-21 09:02:52 PDT
All reviewed patches have been landed. Closing bug.