| Summary: | Crash in convertMainResourceLoadToDownload when downloading file by option-return | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | d235j.1 | ||||||||
| Component: | New Bugs | Assignee: | Anders Carlsson <andersca> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | andersca, commit-queue, d235j.1, japhet, mawu | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | Mac (Intel) | ||||||||||
| OS: | OS X 10.8 | ||||||||||
| Attachments: |
|
||||||||||
Created attachment 202729 [details]
Crash of debug WebKit build
I've attached a crash log of a debug build of WebKit, which should be way more useful. Created attachment 202735 [details]
Patch
Comment on attachment 202735 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=202735&action=review r=me > Source/WebKit2/NetworkProcess/NetworkConnectionToWebProcess.cpp:181 > + if (!mainResourceLoadIdentifier) { > + NetworkProcess::shared().downloadManager().startDownload(downloadID, request); > + return; > + } I think this could use a comment about what mainResourceLoadIdentifier=0 means. Committed r150609: <http://trac.webkit.org/changeset/150609> *** Bug 114672 has been marked as a duplicate of this bug. *** |
Created attachment 202296 [details] Crash log When downloading a loaded page by pressing option-return in the address bar, WebKit may crash with the attached error log. This happens mainly when downloading PDF files, since this is my most common use case, but I believe I've seen it with images and HTML as well. I am using the built-in Apple PDF viewer, not the Adobe Reader plugin, so this should not be a plug-in related issue.