Bug 116441

Summary:

[CSS Regions] Remove the offsetFromLogicalTopOfFirstPage parameter from layout functions

Product:

WebKit

Reporter:

Andrei Bucur <abucur>

Component:

WebCore Misc.

Assignee:

Andrei Bucur <abucur>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achicu, buildbot, commit-queue, eflews.bot, esprehn+autocc, glenn, gtk-ews, gyuyoung.kim, rego+ews, rniwa, WebkitBugTracker, webkit-ews, xan.lopez

Priority:

Keywords:

AdobeTracked

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

116296

Attachments:

Description	Flags
Patch	none
Patch	webkit-ews: commit-queue-
Patch	none
Patch for landing	none

Andrei Bucur

Reported 2013-05-20 08:52:48 PDT

Passing around offsetFromLogicalTopOfFirstPage to the RenderBox/RenderBlock functions seems redundant and it may be bug prone (e.g. the RenderBoxRegionInfo structures are cached for a region not a (region, offset) pair). I think this parameter was added because: - the offset values cached on layout state work only for the current block being laid out - only RenderBlock had offsetFromLogicalTopOfFirstPage() implemented Fix this before trying to change how ranges are computed to simplify the code.

Attachments
Patch (57.03 KB, patch) 2013-05-20 09:03 PDT, Andrei Bucur	no flags	Details Formatted Diff Diff
Patch (68.50 KB, patch) 2013-05-21 07:38 PDT, Andrei Bucur	webkit-ews: commit-queue-	Details Formatted Diff Diff
Patch (69.27 KB, patch) 2013-05-21 08:01 PDT, Andrei Bucur	no flags	Details Formatted Diff Diff
Patch for landing (69.04 KB, patch) 2013-05-27 01:29 PDT, Andrei Bucur	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Andrei Bucur

Comment 1 2013-05-20 09:03:14 PDT

Created attachment 202280 [details] Patch

Early Warning System Bot

Comment 2 2013-05-20 09:09:53 PDT

Comment on attachment 202280 [details] Patch Attachment 202280 [details] did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/497639

Early Warning System Bot

Comment 3 2013-05-20 09:09:59 PDT

Comment on attachment 202280 [details] Patch Attachment 202280 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/383103

kov's GTK+ EWS bot

Comment 4 2013-05-20 09:17:42 PDT

Comment on attachment 202280 [details] Patch Attachment 202280 [details] did not pass gtk-ews (gtk): Output: http://webkit-queues.appspot.com/results/307331

Build Bot

Comment 5 2013-05-20 09:27:37 PDT

Comment on attachment 202280 [details] Patch Attachment 202280 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/299156

Build Bot

Comment 6 2013-05-20 09:30:16 PDT

Comment on attachment 202280 [details] Patch Attachment 202280 [details] did not pass win-ews (win): Output: http://webkit-queues.appspot.com/results/438431

EFL EWS Bot

Comment 7 2013-05-20 10:05:23 PDT

Comment on attachment 202280 [details] Patch Attachment 202280 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/383116

Build Bot

Comment 8 2013-05-20 12:55:26 PDT

Comment on attachment 202280 [details] Patch Attachment 202280 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/289376

EFL EWS Bot

Comment 9 2013-05-20 18:24:23 PDT

Comment on attachment 202280 [details] Patch Attachment 202280 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/527016

Andrei Bucur

Comment 10 2013-05-21 07:38:42 PDT

Created attachment 202427 [details] Patch

Early Warning System Bot

Comment 11 2013-05-21 07:45:26 PDT

Comment on attachment 202427 [details] Patch Attachment 202427 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/525210

EFL EWS Bot

Comment 12 2013-05-21 07:45:49 PDT

Comment on attachment 202427 [details] Patch Attachment 202427 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/524230

Early Warning System Bot

Comment 13 2013-05-21 07:46:51 PDT

Comment on attachment 202427 [details] Patch Attachment 202427 [details] did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/365252

Mihai Maerean

Comment 14 2013-05-21 07:54:41 PDT

Comment on attachment 202427 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=202427&action=review > Source/WebCore/rendering/RenderFlowThread.cpp:1007 > +void RenderFlowThread::popFlowThreadLayoutState() add an assert that you have content to pop.

Andrei Bucur

Comment 15 2013-05-21 08:01:57 PDT

Created attachment 202430 [details] Patch

Dave Hyatt

Comment 16 2013-05-23 14:39:57 PDT

Comment on attachment 202430 [details] Patch r=me. Good patch!

Andrei Bucur

Comment 17 2013-05-27 01:29:09 PDT

Created attachment 202954 [details] Patch for landing

WebKit Commit Bot

Comment 18 2013-05-27 02:41:33 PDT

Comment on attachment 202954 [details] Patch for landing Clearing flags on attachment: 202954 Committed r150743: <http://trac.webkit.org/changeset/150743>

WebKit Commit Bot

Comment 19 2013-05-27 02:41:36 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.