| Summary: | REGRESSION(r150305): WebKit2 build broken with INDEXED_DATABASE enabled | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Carlos Garcia Campos <cgarcia> | ||||
| Component: | WebKit2 | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | andersca, bdakin, cdumez, mrobinson, oleg_smirnov | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 116430 | ||||||
| Attachments: |
|
||||||
Created attachment 202197 [details]
Fix the build
I'm not sure whether this is the right fix or it should be moved to the ui process now, but it fixes the build for now.
*** Bug 116390 has been marked as a duplicate of this bug. *** *** Bug 116396 has been marked as a duplicate of this bug. *** Comment on attachment 202197 [details]
Fix the build
Going to review and land this one since it's a build fix, which means it's blocking forward progress. If someone has a better idea for how to fix this let's work it out later.
Comment on attachment 202197 [details] Fix the build Clearing flags on attachment: 202197 Committed r150344: <http://trac.webkit.org/changeset/150344> All reviewed patches have been landed. Closing bug. |
../../Source/WebKit2/WebProcess/WebPage/WebPageGroupProxy.cpp: In constructor 'WebKit::WebPageGroupProxy::WebPageGroupProxy(const WebKit::WebPageGroupData&)': ../../Source/WebKit2/WebProcess/WebPage/WebPageGroupProxy.cpp:66:84: error: 'class WebKit::WebKeyValueStorageManager' has no member named 'indexedDBDatabaseDirectory' In file included from ../../Source/WebKit2/WebProcess/WebPage/WebPageGroupProxy.cpp:29:0: ../../Source/WebKit2/WebProcess/WebProcess.h: In instantiation of 'T* WebKit::WebProcess::supplement() [with T = WebKit::WebKeyValueStorageManager]': ../../Source/WebKit2/WebProcess/WebPage/WebPageGroupProxy.cpp:65:116: required from here ../../Source/WebKit2/WebProcess/WebProcess.h:90:70: error: invalid static_cast from type 'WTF::HashMap<const char*, WTF::OwnPtr<WebKit::WebProcessSupplement>, WTF::PtrHash<const char*> >::MappedPeekType {aka WebKit::WebProcessSupplement*}' to type 'WebKit::WebKeyValueStorageManager*' ../../Source/WebKit2/WebProcess/WebProcess.h: In member function 'T* WebKit::WebProcess::supplement() [with T = WebKit::WebKeyValueStorageManager]': ../../Source/WebKit2/WebProcess/WebProcess.h:91:5: warning: control reaches end of non-void function [-Wreturn-type] make[1]: *** [Source/WebKit2/WebProcess/WebPage/libwebkit2gtk_3_0_la-WebPageGroupProxy.lo] Error 1 There's no longer WebKeyValueStorageManager in the web process after r150305