Bug 116386

Summary: [EFL][WK2] Refactor ewk_view_custom_encoding_set/get API
Product: WebKit Reporter: Jinwoo Song <jinwoo7.song>
Component: WebKit EFLAssignee: Jinwoo Song <jinwoo7.song>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, gyuyoung.kim, lucas.de.marchi, rakuco
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Jinwoo Song
Reported 2013-05-18 00:13:14 PDT
Handles the 'const char*' parameter in right way and enable the unit test for this API.
Attachments
Patch (4.74 KB, patch)
2013-05-18 00:22 PDT, Jinwoo Song 		no flags
DetailsFormatted DiffDiff
Patch (4.75 KB, patch)
2013-05-18 00:57 PDT, Jinwoo Song 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jinwoo Song
Comment 1 2013-05-18 00:22:03 PDT
Created attachment 202193 [details] Patch
Chris Dumez
Comment 2 2013-05-18 00:41:21 PDT
Comment on attachment 202193 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=202193&action=review Looks good. r=me with a few nit fixes. > Source/WebKit2/ChangeLog:8 > + Refactor the API to handle 'const char*' paramerter in right way and "parameter" > Source/WebKit2/UIProcess/API/efl/EwkView.h:139 > + const char* customTextEncodingName() {return m_customEncoding; } Missing space after '{'. Why isn't the getter const anymore?
Jinwoo Song
Comment 3 2013-05-18 00:56:25 PDT
Comment on attachment 202193 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=202193&action=review >> Source/WebKit2/ChangeLog:8 >> + Refactor the API to handle 'const char*' paramerter in right way and > > "parameter" I will fix. >> Source/WebKit2/UIProcess/API/efl/EwkView.h:139 >> + const char* customTextEncodingName() {return m_customEncoding; } > > Missing space after '{'. Why isn't the getter const anymore? Opps, my bad. This is my first patch with Sublime Text 2 but it seems to be familiar with this more. :)
Jinwoo Song
Comment 4 2013-05-18 00:57:57 PDT
Created attachment 202194 [details] Patch
WebKit Commit Bot
Comment 5 2013-05-18 01:48:13 PDT
Comment on attachment 202194 [details] Patch Clearing flags on attachment: 202194 Committed r150332: <http://trac.webkit.org/changeset/150332>
WebKit Commit Bot
Comment 6 2013-05-18 01:48:16 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.