Bug 116338

Summary: [Windows] Don't use pdevenv when building with VS2010
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: Tools / TestsAssignee: Brent Fulgham <bfulgham>
Severity: Normal CC: bfulgham, commit-queue, dbates
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Description Flags
Patch aroben: review+

Description Brent Fulgham 2013-05-17 11:58:22 PDT
Visual Studio 2005 did not provide a mode for running the build across multiple cores. Consequently, a manual load-splitting system (pdevenv) was created (see <trac.webkit.org/changeset/23775>) to spread the build across available hardware.

Visual Studio 2010 and newer now support the "/MP" flag, which does this for us without requiring Perl scripts or firing off bash shells to do the work.

The new VS2010 project files already have the "/MP" flag turned on.  So the only change needed is for our build scripts to avoid using pdevenv, since this would actually reduce performance compared to the native parallelization feature.
Comment 1 Brent Fulgham 2013-05-17 12:00:20 PDT
Created attachment 202132 [details]
Comment 2 Adam Roben (:aroben) 2013-05-17 12:02:15 PDT
Comment on attachment 202132 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=202132&action=review


> Tools/ChangeLog:11
> +        * Scripts/webkitdirs.pm:
> +        (setupCygwinEnv): Check if we are using VS2005, and only use
> +        the 'pdevenv' hack if we are. Otherwise, just build with
> +        our standard project.

Might be worth mentioning somewhere in here that the VS2010 build is already compiling files in parallel.
Comment 3 Brent Fulgham 2013-05-17 12:06:13 PDT
Committed r150281: <http://trac.webkit.org/changeset/150281>