Bug 116325

Summary: Add WKPageLoadData and WKPageLoadDataWithUserData SPI to support loading arbitrary data blobs
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch simon.fraser: review+

Sam Weinig
Reported 2013-05-17 09:58:26 PDT
Add WKPageLoadData and WKPageLoadDataWithUserData SPI to support loading arbritrary data blobs
Attachments
Patch (11.82 KB, patch)
2013-05-17 10:00 PDT, Sam Weinig 		simon.fraser: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2013-05-17 10:00:34 PDT
Created attachment 202106 [details] Patch
Simon Fraser (smfr)
Comment 2 2013-05-17 10:09:10 PDT
Comment on attachment 202106 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=202106&action=review > Source/WebKit2/UIProcess/API/C/WKPage.h:369 > +WK_EXPORT void WKPageLoadData(WKPageRef page, WKDataRef data, WKStringRef MIMEType, WKStringRef encoding, WKURLRef baseURL); > +WK_EXPORT void WKPageLoadDataWithUserData(WKPageRef page, WKDataRef data, WKStringRef MIMEType, WKStringRef encoding, WKURLRef baseURL, WKTypeRef userData); Do these need to be distinct? Can't we just have a userData param in LoadData?
Sam Weinig
Comment 3 2013-05-17 10:25:13 PDT
(In reply to comment #2) > (From update of attachment 202106 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=202106&action=review > > > Source/WebKit2/UIProcess/API/C/WKPage.h:369 > > +WK_EXPORT void WKPageLoadData(WKPageRef page, WKDataRef data, WKStringRef MIMEType, WKStringRef encoding, WKURLRef baseURL); > > +WK_EXPORT void WKPageLoadDataWithUserData(WKPageRef page, WKDataRef data, WKStringRef MIMEType, WKStringRef encoding, WKURLRef baseURL, WKTypeRef userData); > > Do these need to be distinct? Can't we just have a userData param in LoadData? I am trying to keep consistency.
Sam Weinig
Comment 4 2013-05-17 10:30:23 PDT
Committed r150271: <http://trac.webkit.org/changeset/150271>
Note You need to log in before you can comment on or make changes to this bug.