Bug 116325 - Add WKPageLoadData and WKPageLoadDataWithUserData SPI to support loading arbitrary data blobs
Summary: Add WKPageLoadData and WKPageLoadDataWithUserData SPI to support loading arbi...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-05-17 09:58 PDT by Sam Weinig
Modified: 2013-05-17 10:30 PDT (History)
0 users

See Also:

Attachments
Patch (11.82 KB, patch)
2013-05-17 10:00 PDT, Sam Weinig 		simon.fraser: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2013-05-17 09:58:26 PDT 
Add WKPageLoadData and WKPageLoadDataWithUserData SPI to support loading arbritrary data blobs
Comment 1 Sam Weinig 2013-05-17 10:00:34 PDT 
Created attachment 202106 [details]
Patch
Comment 2 Simon Fraser (smfr) 2013-05-17 10:09:10 PDT 
Comment on attachment 202106 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=202106&action=review

> Source/WebKit2/UIProcess/API/C/WKPage.h:369
> +WK_EXPORT void WKPageLoadData(WKPageRef page, WKDataRef data, WKStringRef MIMEType, WKStringRef encoding, WKURLRef baseURL);
> +WK_EXPORT void WKPageLoadDataWithUserData(WKPageRef page, WKDataRef data, WKStringRef MIMEType, WKStringRef encoding, WKURLRef baseURL, WKTypeRef userData);

Do these need to be distinct? Can't we just have a userData param in LoadData?
Comment 3 Sam Weinig 2013-05-17 10:25:13 PDT 
(In reply to comment #2)
> (From update of attachment 202106 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=202106&action=review
> 
> > Source/WebKit2/UIProcess/API/C/WKPage.h:369
> > +WK_EXPORT void WKPageLoadData(WKPageRef page, WKDataRef data, WKStringRef MIMEType, WKStringRef encoding, WKURLRef baseURL);
> > +WK_EXPORT void WKPageLoadDataWithUserData(WKPageRef page, WKDataRef data, WKStringRef MIMEType, WKStringRef encoding, WKURLRef baseURL, WKTypeRef userData);
> 
> Do these need to be distinct? Can't we just have a userData param in LoadData?

I am trying to keep consistency.
Comment 4 Sam Weinig 2013-05-17 10:30:23 PDT 
Committed r150271: <http://trac.webkit.org/changeset/150271>