Bug 116324

Summary: Make kit(Frame*) more robust
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Severity: Normal CC: beidson
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Description Flags
Patch darin: review+

Description Anders Carlsson 2013-05-17 09:52:34 PDT
Make kit(Frame*) more robust
Comment 1 Anders Carlsson 2013-05-17 09:54:17 PDT
Created attachment 202104 [details]
Comment 2 Darin Adler 2013-05-17 09:55:57 PDT
Comment on attachment 202104 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=202104&action=review

> Source/WebKit/mac/WebView/WebFrame.mm:234
> +    FrameLoaderClient* frameLoaderClient = frame->loader()->client();
> +    if (frameLoaderClient->isEmptyFrameLoaderClient())
> +        return nil;

Man that really stinks. I wondered why you were doing this refactoring.

I would have named the local variable just client.
Comment 3 Anders Carlsson 2013-05-17 09:58:35 PDT
Committed r150269: <http://trac.webkit.org/changeset/150269>
Comment 4 Brady Eidson 2013-05-17 12:21:41 PDT
*** Bug 116255 has been marked as a duplicate of this bug. ***