Bug 116324

Summary: Make kit(Frame*) more robust
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal CC: beidson
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch darin: review+

Anders Carlsson
Reported 2013-05-17 09:52:34 PDT
Make kit(Frame*) more robust
Attachments
Patch (1.57 KB, patch)
2013-05-17 09:54 PDT, Anders Carlsson 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2013-05-17 09:54:17 PDT
Created attachment 202104 [details] Patch
Darin Adler
Comment 2 2013-05-17 09:55:57 PDT
Comment on attachment 202104 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=202104&action=review > Source/WebKit/mac/WebView/WebFrame.mm:234 > + FrameLoaderClient* frameLoaderClient = frame->loader()->client(); > + if (frameLoaderClient->isEmptyFrameLoaderClient()) > + return nil; Man that really stinks. I wondered why you were doing this refactoring. I would have named the local variable just client.
Anders Carlsson
Comment 3 2013-05-17 09:58:35 PDT
Committed r150269: <http://trac.webkit.org/changeset/150269>
Brady Eidson
Comment 4 2013-05-17 12:21:41 PDT
*** Bug 116255 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.