Summary: | [CSSRegions] Constrain auto-height region computation in a different way | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Mihnea Ovidenie <mihnea> | ||||||
Component: | CSS | Assignee: | Mihnea Ovidenie <mihnea> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | achicu, commit-queue, esprehn+autocc, glenn, WebkitBugTracker | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Mihnea Ovidenie
2013-05-17 06:30:26 PDT
Created attachment 202077 [details]
Patch
Comment on attachment 202077 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=202077&action=review Looks good. Please, add a separate bug to track the other issue. > Source/WebCore/ChangeLog:10 > + Covered by existing regions tests, since when replaced-based the region had an intrinsic height of 0 and now, block-based, it does not have any children. We will need to add a test for regions with "box-sizing: border-box" and "height: auto". Looks like both the previous and the new functions subtract the padding out of your height. (In reply to comment #2) > (From update of attachment 202077 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=202077&action=review > > Looks good. Please, add a separate bug to track the other issue. > > > Source/WebCore/ChangeLog:10 > > + Covered by existing regions tests, since when replaced-based the region had an intrinsic height of 0 and now, block-based, it does not have any children. > > We will need to add a test for regions with "box-sizing: border-box" and "height: auto". Looks like both the previous and the new functions subtract the padding out of your height. Added bug: https://bugs.webkit.org/show_bug.cgi?id=116518 to track this issue. Created attachment 202387 [details]
Patch for landing
The commit-queue encountered the following flaky tests while processing attachment 202387 [details]: media/track/track-remove-crash.html bug 115892 (author: eric.carlson@apple.com) svg/batik/text/textFeatures.svg bug 116326 (authors: darin@apple.com and zimmermann@kde.org) svg/batik/text/textLength.svg bug 116329 (authors: darin@apple.com and zimmermann@kde.org) svg/batik/text/textEffect3.svg bug 116521 (authors: darin@apple.com and zimmermann@kde.org) compositing/overflow/overflow-compositing-descendant.html bug 116485 (authors: mihaip@chromium.org, rniwa@webkit.org, and simon.fraser@apple.com) editing/inserting/typing-at-end-of-line.html bug 116486 (author: enrica@apple.com) The commit-queue is continuing to process your patch. Comment on attachment 202387 [details] Patch for landing Clearing flags on attachment: 202387 Committed r150427: <http://trac.webkit.org/changeset/150427> All reviewed patches have been landed. Closing bug. |