Bug 116291

Summary: Minor String fixes in CSS
Product: WebKit Reporter: Benjamin Poulain <benjamin>
Component: New BugsAssignee: Benjamin Poulain <benjamin>
Status: RESOLVED FIXED    
Severity: Normal CC: allan.jensen, commit-queue, eric.carlson, esprehn+autocc, glenn, jer.noble, macpherson, menard, webkit-ews
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Benjamin Poulain
Reported 2013-05-16 22:42:31 PDT
Minor String fixes in CSS
Attachments
Patch (21.12 KB, patch)
2013-05-16 22:48 PDT, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
Patch (21.15 KB, patch)
2013-05-20 13:27 PDT, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Benjamin Poulain
Comment 1 2013-05-16 22:48:27 PDT
Created attachment 202046 [details] Patch
Early Warning System Bot
Comment 2 2013-05-16 22:54:05 PDT
Comment on attachment 202046 [details] Patch Attachment 202046 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/481795
Build Bot
Comment 3 2013-05-16 23:13:33 PDT
Comment on attachment 202046 [details] Patch Attachment 202046 [details] did not pass win-ews (win): Output: http://webkit-queues.appspot.com/results/494163
Early Warning System Bot
Comment 4 2013-05-17 04:01:59 PDT
Comment on attachment 202046 [details] Patch Attachment 202046 [details] did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/483672
Darin Adler
Comment 5 2013-05-17 08:59:00 PDT
Comment on attachment 202046 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=202046&action=review r=me if you fix the thing I noticed, and get Qt and Windows building > Source/WebCore/css/CSSPropertySourceData.cpp:92 > - DEFINE_STATIC_LOCAL(String, emptyValue, (ASCIILiteral("e"))); > - DEFINE_STATIC_LOCAL(String, importantSuffix, (ASCIILiteral(" !important"))); > - if (!name && value == emptyValue) > + if (!name && value[0] == 'e') This changes behavior. It now only checks that the first letter is e, rather than checking that the entire string is "e". Is that OK? Is there test coverage?
Benjamin Poulain
Comment 6 2013-05-20 13:27:30 PDT
Created attachment 202314 [details] Patch
Benjamin Poulain
Comment 7 2013-05-20 22:57:20 PDT
Comment on attachment 202314 [details] Patch Clearing flags on attachment: 202314 Committed r150417: <http://trac.webkit.org/changeset/150417>
Benjamin Poulain
Comment 8 2013-05-20 22:57:24 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.