Bug 116254

Summary: Remove WKBundlePageGetHeaderLayer/Footer SPI
Product: WebKit Reporter: Beth Dakin <bdakin>
Component: WebKit APIAssignee: Beth Dakin <bdakin>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, bdakin, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch benjamin: review+, benjamin: commit-queue-

Description Beth Dakin 2013-05-16 17:11:27 PDT 
We should remove the Remove WKBundlePageGetHeaderLayer/Footer SPI. It was only recently added and have been replaced by WKBundlePageSetHeaderBanner/Footer.
Comment 1 Beth Dakin 2013-05-16 17:12:01 PDT 
Created attachment 202005 [details]
Patch
Comment 2 Benjamin Poulain 2013-05-16 17:33:04 PDT 
Comment on attachment 202005 [details]
Patch

A changelog would be nice ;)
Comment 3 Benjamin Poulain 2013-05-16 17:33:36 PDT 
Comment on attachment 202005 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=202005&action=review

> Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm:826
> +{    

Extra spaces here.
Comment 4 Beth Dakin 2013-05-16 21:42:23 PDT 
(In reply to comment #2)
> (From update of attachment 202005 [details])
> A changelog would be nice ;)

Heh, good call. Thanks for the review!
Comment 5 Beth Dakin 2013-05-16 22:22:54 PDT 
http://trac.webkit.org/changeset/150243